From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id CC3D4201 for ; Fri, 6 Jan 2017 04:25:54 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP; 05 Jan 2017 19:25:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,323,1477983600"; d="scan'208";a="1108671265" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 05 Jan 2017 19:25:53 -0800 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 5 Jan 2017 19:25:53 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 5 Jan 2017 19:25:52 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX103.ccr.corp.intel.com ([10.239.4.69]) with mapi id 14.03.0248.002; Fri, 6 Jan 2017 11:25:51 +0800 From: "Lu, Wenzhuo" To: "Wu, Jingjing" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v7 05/27] net/i40e: set Tx loopback from PF Thread-Index: AQHSZY5meG5AJWmTQEylrIzYETN1OKEqF48AgACxMJA= Date: Fri, 6 Jan 2017 03:25:50 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B55645A@shsmsx102.ccr.corp.intel.com> References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com> <1483426488-117332-1-git-send-email-wenzhuo.lu@intel.com> <1483426488-117332-6-git-send-email-wenzhuo.lu@intel.com> <9BB6961774997848B5B42BEC655768F810CC3C9B@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F810CC3C9B@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 05/27] net/i40e: set Tx loopback from PF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jan 2017 03:25:55 -0000 Hi Jingjing, > -----Original Message----- > From: Wu, Jingjing > Sent: Friday, January 6, 2017 8:33 AM > To: Lu, Wenzhuo; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH v7 05/27] net/i40e: set Tx loopback from P= F >=20 > Is the Tx lookback meaning as VEB mode ore VEPA mode? > If so, how about change the API's name to set_switch_mode? Yes. It means changing the switch mode between VEB and VEPA. As ixgbe is already using this name. Better to keep it now. We can consider= changing both of them later. >=20 > Another comment is: you removed all mac vlan filters before changing The > mode, and restore them after changing. How about vlan filters? The Patch = for > vlan anti-spoof enables it, correct? Yes, the vlan table is operated when setting vlan anti-spoofing. Better to = do the same thing for it here. >=20 > Thanks > JIngjing >=20