From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B23EAFA63 for ; Fri, 20 Jan 2017 03:14:53 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 19 Jan 2017 18:14:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,256,1477983600"; d="scan'208";a="1085112264" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 19 Jan 2017 18:14:52 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 19 Jan 2017 18:14:52 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 19 Jan 2017 18:14:52 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.177]) with mapi id 14.03.0248.002; Fri, 20 Jan 2017 10:14:49 +0800 From: "Lu, Wenzhuo" To: Adrien Mazarguil , Thomas Monjalon CC: "Liu, Yong" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] doc: announce ABI change for cloud filter Thread-Index: AQHSchWXZWPuadPn0US5riLOuNd7rqE+/GIAgACh2wCAAP/PwA== Date: Fri, 20 Jan 2017 02:14:49 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B55C21C@shsmsx102.ccr.corp.intel.com> References: <1484804043-50156-1-git-send-email-yong.liu@intel.com> <2857373.EhiM2j9T0R@xps13> <20170119184552.GB3779@6wind.com> In-Reply-To: <20170119184552.GB3779@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for cloud filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2017 02:14:54 -0000 Hi Adrien, Thomas, Yong, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Adrien Mazarguil > Sent: Friday, January 20, 2017 2:46 AM > To: Thomas Monjalon > Cc: Liu, Yong; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for cloud filter >=20 > On Thu, Jan 19, 2017 at 10:06:34AM +0100, Thomas Monjalon wrote: > > 2017-01-19 13:34, Yong Liu: > > > +* ABI changes are planned for 17.05: structure > > > +``rte_eth_tunnel_filter_conf`` > > > + will be extended with a new member ``vf_id`` in order to enable > > > +cloud filter > > > + on VF device. > > > > I think we should stop rely on this API, and migrate to rte_flow instea= d. > > Adrien any thought? >=20 > I'm all for using rte_flow in any case. I've already documented an approa= ch to > convert TUNNEL filter rules to rte_flow rules [1], although it may be > incomplete due to my limited experience with this filter type. We already > know several tunnel item types must be added (currently only VXLAN is > defined). >=20 > I understand ixgbe/i40e currently map rte_flow on top of the legacy > framework, therefore extending this structure might still be needed in th= e > meantime. Not sure we should prevent this change as long as such rules ca= n be > configured through rte_flow as well. >=20 > [1] http://dpdk.org/doc/guides/prog_guide/rte_flow.html#tunnel-to-eth-ipv= 4- > ipv6-vxlan-or-other-queue The problem is we haven't finished transferring all the functions from the = regular filters to the generic filters.=20 For example, igb, fm10k and enic haven't support generic filters yet. Ixgbe= and i40e have supported the basic functions, but some advance features are= not transferred to generic filters yet. Seems it's not the time to remove the regular filters. Yong, I suggest to s= upport both generic filter and regular filter in parallel. So, we need to announce ABI change for the regular filter, until someday we= remove the regular filter API.=20 >=20 > -- > Adrien Mazarguil > 6WIND