From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 1E9C42B88 for ; Fri, 24 Feb 2017 08:23:15 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP; 23 Feb 2017 23:23:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,200,1484035200"; d="scan'208";a="827946198" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 23 Feb 2017 23:23:14 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 23 Feb 2017 23:23:14 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 23 Feb 2017 23:23:14 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX103.ccr.corp.intel.com ([10.239.4.69]) with mapi id 14.03.0248.002; Fri, 24 Feb 2017 15:23:12 +0800 From: "Lu, Wenzhuo" To: Stephen Hemminger CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 0/8] QoS features on i40e Thread-Index: AQHSjk2E7nmNICY/IUCDz1VuWtB3dqF3MyaAgACIdaA= Date: Fri, 24 Feb 2017 07:23:12 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5682B7@shsmsx102.ccr.corp.intel.com> References: <1487906675-54260-1-git-send-email-wenzhuo.lu@intel.com> <20170223225507.69ee0e47@xeon-e3> In-Reply-To: <20170223225507.69ee0e47@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/8] QoS features on i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2017 07:23:16 -0000 Hi Stephen, > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Friday, February 24, 2017 2:55 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/8] QoS features on i40e >=20 > On Fri, 24 Feb 2017 11:24:27 +0800 > Wenzhuo Lu wrote: >=20 > > This patch set enables several QoS features on i40e. > > 1, VF max bandwidth setting. > > 2, TC min bandwidth setting on a VF. > > 3, TC max bandwidth setting on a VF. > > 4, TC TX scheduling mode setting. > > As there're no new interface between PF and VF defined, all the > > settings for VF are done on PF. PF acts as a controller for the VFs. > > > > Wenzhuo Lu (8): > > net/i40e: set VF max bandwidth from PF > > net/i40e: allocate VF TC bandwidth from PF > > net/i40e: set VF TC max bandwidth from PF > > net/i40e: set TC strict priority mode > > app/testpmd: set VF TX max bandwidth > > app/testpmd: set VF TC TX min bandwidth > > app/testpmd: set VF TC TX max bandwidth > > app/testpmd: set TC strict link priority mode > > > > app/test-pmd/cmdline.c | 343 ++++++++++++++++++++= + > > doc/guides/nics/i40e.rst | 21 ++ > > doc/guides/rel_notes/release_17_05.rst | 20 ++ > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 28 ++ > > drivers/net/i40e/i40e_ethdev.c | 449 > ++++++++++++++++++++++++++++ > > drivers/net/i40e/i40e_ethdev.h | 1 + > > drivers/net/i40e/rte_pmd_i40e.h | 86 ++++++ > > drivers/net/i40e/rte_pmd_i40e_version.map | 10 + > > 8 files changed, 958 insertions(+) > > >=20 > It is good to allow setting QoS on device, but it looks like this is a de= vice > specific API, not a generic PMD function. I don't think any feature in DP= DK > should be hardcoded to one device type. Yes, they're private APIs. Normally we want to support kernel PF + dpdk VF. As there's no PF - VF inte= rface defined for QoS, These features cannot be implemented on VF now. Have to put them on PF, and let PF play as a controller. There's discussion about if we should rich PF host features. So, I put thes= e functions to rte_pmd_i40e.h to show they're experimental and temporary fe= atures. There's another thread started by Cristian for a generic QoS solution. Afte= r it's accepted and the PF-VF interfaces are defined by kernel driver. We c= an use a generic solution to replace this one.