From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 587302BB2 for ; Tue, 28 Feb 2017 02:07:34 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2017 17:07:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,216,1484035200"; d="scan'208";a="70890153" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga006.fm.intel.com with ESMTP; 27 Feb 2017 17:07:33 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 27 Feb 2017 17:07:33 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.204]) with mapi id 14.03.0248.002; Tue, 28 Feb 2017 09:07:30 +0800 From: "Lu, Wenzhuo" To: Billy McFall , "thomas.monjalon@6wind.com" , "olivier.matz@6wind.com" CC: "dev@dpdk.org" Thread-Topic: [PATCH v5 2/3] net/e1000: e1000 igb support to free consumed buffers Thread-Index: AQHSeMyJ08zeCvl190aqtTsXTNjkiaF9yZlQ Date: Tue, 28 Feb 2017 01:07:30 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5691E4@shsmsx102.ccr.corp.intel.com> References: <20170123211340.22570-1-bmcfall@redhat.com> <20170127183800.27466-1-bmcfall@redhat.com> <20170127183800.27466-3-bmcfall@redhat.com> In-Reply-To: <20170127183800.27466-3-bmcfall@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 2/3] net/e1000: e1000 igb support to free consumed buffers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 01:07:34 -0000 Hi Billy, > -----Original Message----- > From: Billy McFall [mailto:bmcfall@redhat.com] > Sent: Saturday, January 28, 2017 2:38 AM > To: thomas.monjalon@6wind.com; Lu, Wenzhuo; olivier.matz@6wind.com > Cc: dev@dpdk.org; Billy McFall > Subject: [PATCH v5 2/3] net/e1000: e1000 igb support to free consumed buf= fers >=20 > Add support to the e1000 igb driver for the new API to force free consume= d > buffers on Tx ring. e1000 igb driver does not implement a tx_rs_thresh to= free > mbufs, it frees a slot in the ring as needed, so a new function needed to= be > written. There's another question about this commit log. As we know tx_rs_thresh is = not supported by igb. But I think it can be implemented. Your idea is to add an API, so APP can free the buffers explicitly. It's a= different idea with threshold, right? Seems this log is a little misleadin= g.