From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 8EB2ACFFE for ; Mon, 13 Mar 2017 04:15:54 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP; 12 Mar 2017 20:15:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,156,1486454400"; d="scan'208";a="59448308" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 12 Mar 2017 20:15:52 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 12 Mar 2017 20:15:52 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 12 Mar 2017 20:15:52 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX103.ccr.corp.intel.com ([10.239.4.69]) with mapi id 14.03.0248.002; Mon, 13 Mar 2017 11:15:50 +0800 From: "Lu, Wenzhuo" To: "Legacy, Allain (Wind River)" CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/e1000: advertise offload capabilities for the EM PMD Thread-Index: AQHSmawi9tX1KJokLkqzQS2DRU38rqGSHLFA Date: Mon, 13 Mar 2017 03:15:49 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B56EE2A@shsmsx102.ccr.corp.intel.com> References: <1489156701-185471-1-git-send-email-allain.legacy@windriver.com> In-Reply-To: <1489156701-185471-1-git-send-email-allain.legacy@windriver.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/e1000: advertise offload capabilities for the EM PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Mar 2017 03:15:54 -0000 Hi, > -----Original Message----- > From: Allain Legacy [mailto:allain.legacy@windriver.com] > Sent: Friday, March 10, 2017 10:38 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: [PATCH] net/e1000: advertise offload capabilities for the EM PMD >=20 > The hardware offload capabilities are not being advertised for the EM PMD= . > Because of this, applications that only enable these features if the devi= ce > advertises them will never do so. >=20 > Normally this is not an issue since normal packet processing should work = even if > hardware offload is not available. But, in older versions of Virtual Box= the e1000 > device emulation (Intel PRO/1000 MT Desktop 82540EM) assumes that it shou= ld > enable VLAN stripping even if the driver does not request it. This means= that any > ingress packets that have a VLAN tag will be stripped. Since the applica= tion did > not request to enable VLAN stripping it is not expecting these packets so= they > are not processed as VLAN packets. >=20 > Regardless of the Virtual Box issue, the driver should be advertising sup= ported > capabilities as is done in other drivers. >=20 > Signed-off-by: Allain Legacy Acked-by: Wenzhuo Lu