From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id DE05369A5 for ; Fri, 24 Mar 2017 08:07:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490339251; x=1521875251; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=6iM6HVY8m3Cs5BOnDPJ0GoN/YdP+mxOgTy+ew/ulBGc=; b=P9eYw2b7tXJnrdwZdbc2vpk+PuOGwXYkFAVSFgSdWluWcnw7pKPMSXGH c6QHy2uuLyip0IISsYcX7c6j1bFDbQ==; Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Mar 2017 00:07:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,213,1486454400"; d="scan'208";a="1111695629" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 24 Mar 2017 00:07:29 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 24 Mar 2017 00:07:29 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 24 Mar 2017 00:07:29 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.212]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.253]) with mapi id 14.03.0248.002; Fri, 24 Mar 2017 15:07:27 +0800 From: "Lu, Wenzhuo" To: "Wu, Jingjing" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 4/8] net/i40e: set TC strict priority mode Thread-Index: AQHSjk2RRSi6wLuDK0mYxdc/MHPwK6GjGc0AgACh9+A= Date: Fri, 24 Mar 2017 07:07:26 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B57F136@shsmsx102.ccr.corp.intel.com> References: <1487906675-54260-1-git-send-email-wenzhuo.lu@intel.com> <1487906675-54260-5-git-send-email-wenzhuo.lu@intel.com> <9BB6961774997848B5B42BEC655768F810D1061B@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F810D1061B@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 4/8] net/i40e: set TC strict priority mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Mar 2017 07:07:31 -0000 Hi Jingjing, > -----Original Message----- > From: Wu, Jingjing > Sent: Friday, March 24, 2017 1:20 PM > To: Lu, Wenzhuo; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH 4/8] net/i40e: set TC strict priority mode >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > > Sent: Friday, February 24, 2017 11:25 AM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo > > Subject: [dpdk-dev] [PATCH 4/8] net/i40e: set TC strict priority mode > > > > Set some TCs to strict priority mode. > > It's a global setting on a physical port. > > > > Signed-off-by: Wenzhuo Lu > > --- > > doc/guides/nics/i40e.rst | 10 +++ > > doc/guides/rel_notes/release_17_05.rst | 7 ++ > > drivers/net/i40e/i40e_ethdev.c | 119 > > ++++++++++++++++++++++++++++++ > > drivers/net/i40e/i40e_ethdev.h | 1 + > > drivers/net/i40e/rte_pmd_i40e.h | 15 ++++ > > drivers/net/i40e/rte_pmd_i40e_version.map | 1 + > > 6 files changed, 153 insertions(+) > > > > diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index > > 260287e..361d9d9 100644 > > --- a/doc/guides/nics/i40e.rst > > +++ b/doc/guides/nics/i40e.rst > > @@ -478,3 +478,13 @@ enabled. If so, return failure. > > When enabling per TC max bandwidth, SW will check if per VF max > > bandwidth is enabled. If so, disable per VF max bandwidth and continue > > with per TC max bandwidth setting. > > + > > +TC TX scheduling mode setting > > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > + > > +There're 2 TX scheduling modes for TCs, round robin and strict priorit= y > mode. > > +If a TC is set to strict priority mode, it can consume unlimited bandw= idth. > > +It means if APP has set the max bandwidth for that TC, it comes to no > > +effect. > > +It's suggested to set the strict priority mode for a TC that is > > +latency sensitive but no consuming much bandwidth. > > diff --git a/doc/guides/rel_notes/release_17_05.rst > > b/doc/guides/rel_notes/release_17_05.rst > > index d31435c..99811a2 100644 > > --- a/doc/guides/rel_notes/release_17_05.rst > > +++ b/doc/guides/rel_notes/release_17_05.rst > > @@ -55,6 +55,13 @@ New Features > > i40e HW supports to set the max bandwidth for a TC on a VF. Enable t= his > > capability. > > > > +* **Added TC strict priority mode setting on i40e.** > > + > > + There're 2 TX scheduling modes supported for TCs by i40e HW, round > > + ribon mode and strict priority mode. By default it's round robin > > + mode. Enable the capability to change the TX scheduling mode for a > > + TC. It's a global setting on a physical port. > > + > > Resolved Issues >=20 >=20 > > + if (!veb->strict_prio_tc) > > + ret =3D i40e_aq_config_switch_comp_ets( > > + hw, veb->uplink_seid, > > + &ets_data, > i40e_aqc_opc_enable_switching_comp_ets, > > + NULL); >=20 > How about to check the tc_map when the first time to set strict_prio_tc? Thanks for the comment. I didn't consider that before. But I checked my patch, in the previous code, I've checked if tc_map is equ= al to strict_prio_tc. So if it's the first time to set strict_prio_tc, tc_m= ap cannot be 0. Lucky :)