From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id F195F377A for ; Fri, 21 Apr 2017 04:35:30 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Apr 2017 19:35:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,228,1488873600"; d="scan'208";a="77040491" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 20 Apr 2017 19:35:29 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 20 Apr 2017 19:35:29 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0319.002; Fri, 21 Apr 2017 10:35:27 +0800 From: "Lu, Wenzhuo" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "Zhao1, Wei" Thread-Topic: [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type check Thread-Index: AQHSuYccRUv/CblsKEewWkjpe0Pwk6HPHI9A Date: Fri, 21 Apr 2017 02:35:27 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B59B4DA@shsmsx102.ccr.corp.intel.com> References: <1492658865-30077-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1492658865-30077-1-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Apr 2017 02:35:31 -0000 Hi Wei, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao > Sent: Thursday, April 20, 2017 11:28 AM > To: dev@dpdk.org > Cc: Zhao1, Wei > Subject: [dpdk-dev] [PATCH 1/2] net/ixgbe: remove a useless item type che= ck >=20 > Remove a useless item type check for fdir flow rule. >=20 > Fixes: 11777435c72 ("net/ixgbe: parse flow director filter") >=20 > Signed-off-by: Wei Zhao > --- > drivers/net/ixgbe/ixgbe_flow.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flo= w.c > index 7ce740e..11d8cc9 100644 > --- a/drivers/net/ixgbe/ixgbe_flow.c > +++ b/drivers/net/ixgbe/ixgbe_flow.c > @@ -2346,16 +2346,9 @@ ixgbe_parse_fdir_filter_tunnel(const struct > rte_flow_attr *attr, > RTE_FLOW_ERROR_TYPE_ITEM, > item, "Not supported by fdir filter"); > return -rte_errno; > - } else if (item->type !=3D RTE_FLOW_ITEM_TYPE_END) { > - memset(rule, 0, sizeof(struct ixgbe_fdir_rule)); > - rte_flow_error_set(error, EINVAL, > - RTE_FLOW_ERROR_TYPE_ITEM, > - item, "Not supported by fdir filter"); > - return -rte_errno; > } Seems the item type only can be END. Why not remove the VLAN check either? > + > /* check if the next not void item is END */ > - index++; > - NEXT_ITEM_OF_PATTERN(item, pattern, index); > if (item->type !=3D RTE_FLOW_ITEM_TYPE_END) { > memset(rule, 0, sizeof(struct ixgbe_fdir_rule)); > rte_flow_error_set(error, EINVAL, > -- > 2.9.3