From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 08348388F for ; Fri, 21 Apr 2017 04:48:36 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Apr 2017 19:48:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,228,1488873600"; d="scan'208";a="90464920" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 20 Apr 2017 19:48:35 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 20 Apr 2017 19:48:34 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 20 Apr 2017 19:48:34 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.193]) with mapi id 14.03.0319.002; Fri, 21 Apr 2017 10:48:32 +0800 From: "Lu, Wenzhuo" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "Zhao1, Wei" Thread-Topic: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix a error type check for flow type Thread-Index: AQHSuYcwBhr56xOktk69wrmsbdO3kKHPIDpg Date: Fri, 21 Apr 2017 02:48:32 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B59B4F8@shsmsx102.ccr.corp.intel.com> References: <1492658865-30077-1-git-send-email-wei.zhao1@intel.com> <1492658865-30077-2-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1492658865-30077-2-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix a error type check for flow type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Apr 2017 02:48:37 -0000 Hi Wei, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao > Sent: Thursday, April 20, 2017 11:28 AM > To: dev@dpdk.org > Cc: Zhao1, Wei > Subject: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix a error type check for flo= w > type >=20 > The type check for flow_type should be IXGBE_ATR_FLOW_TYPE_IPV4 in > special card not RTE_ETH_FLOW_NONFRAG_IPV4_OTHER. >=20 > Fixes: dc0c16105d2 ("ixgbe: fix X550 flow director check") >=20 > Signed-off-by: Wei Zhao > --- > drivers/net/ixgbe/ixgbe_fdir.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdi= r.c > index 3b9d60c..6f19b91 100644 > --- a/drivers/net/ixgbe/ixgbe_fdir.c > +++ b/drivers/net/ixgbe/ixgbe_fdir.c > @@ -1241,7 +1241,7 @@ ixgbe_fdir_filter_program(struct rte_eth_dev *dev, > hw->mac.type =3D=3D ixgbe_mac_X550EM_x || > hw->mac.type =3D=3D ixgbe_mac_X550EM_a) && > (rule->ixgbe_fdir.formatted.flow_type =3D=3D > - RTE_ETH_FLOW_NONFRAG_IPV4_OTHER) && > + IXGBE_ATR_FLOW_TYPE_IPV4) && > (info->mask.src_port_mask !=3D 0 || > info->mask.dst_port_mask !=3D 0)) { > PMD_DRV_LOG(ERR, "By this device," > -- > 2.9.3 It's a good fix. But please change the comments and error log accordingly.