From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 821FD58D1; Thu, 27 Apr 2017 07:41:36 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP; 26 Apr 2017 22:41:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,257,1488873600"; d="scan'208";a="1140710623" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga001.fm.intel.com with ESMTP; 26 Apr 2017 22:41:34 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 26 Apr 2017 22:41:34 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 26 Apr 2017 22:41:34 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.224]) with mapi id 14.03.0319.002; Thu, 27 Apr 2017 13:41:31 +0800 From: "Lu, Wenzhuo" To: "Yang, Qiming" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH] net/e1000: fix vf received problem Thread-Index: AQHSvxWSG8+yPwloJUySp6JOg32KjaHYs2dA Date: Thu, 27 Apr 2017 05:41:29 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B59D241@shsmsx102.ccr.corp.intel.com> References: <1493269649-56200-1-git-send-email-qiming.yang@intel.com> In-Reply-To: <1493269649-56200-1-git-send-email-qiming.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix vf received problem X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Apr 2017 05:41:37 -0000 Hi Qiming, > -----Original Message----- > From: Yang, Qiming > Sent: Thursday, April 27, 2017 1:07 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo; stable@dpdk.org; Yang, Qiming > Subject: [PATCH] net/e1000: fix vf received problem >=20 > VF default MAC address be added in PF Mac address list instead of VF MAC > address list, makes VF can't recieve packets. This patch fixes this issue= . >=20 > Fixes: be2d648a2dd3 ("igb: add PF support") >=20 > Signed-off-by: Qiming Yang > --- > drivers/net/e1000/igb_pf.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/drivers/net/e1000/igb_pf.c b/drivers/net/e1000/igb_pf.c inde= x > 67da3c2..1a70ad5 100644 > --- a/drivers/net/e1000/igb_pf.c > +++ b/drivers/net/e1000/igb_pf.c > @@ -338,6 +338,9 @@ igb_vf_set_mac_addr(struct rte_eth_dev *dev, > uint32_t vf, uint32_t *msgbuf) > rte_memcpy(vfinfo[vf].vf_mac_addresses, new_mac, > sizeof(vfinfo[vf].vf_mac_addresses)); > hw->mac.ops.rar_set(hw, new_mac, rar_entry); > + int rah =3D E1000_READ_REG(hw, E1000_RAH(rar_entry)); Looks a little weird to define rah here. Would you like to move it to the b= eginning? Thanks. > + rah |=3D (0x1 << (E1000_RAH_POOLSEL_SHIFT + vf)); > + E1000_WRITE_REG(hw, E1000_RAH(rar_entry), rah); > return 0; > } > return -1; > -- > 2.7.4