From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id AFE1A9E3 for ; Fri, 28 Apr 2017 02:49:23 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Apr 2017 17:49:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,386,1488873600"; d="scan'208";a="79854536" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 27 Apr 2017 17:49:21 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 27 Apr 2017 17:49:21 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 27 Apr 2017 17:49:21 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.217]) with mapi id 14.03.0319.002; Fri, 28 Apr 2017 08:49:19 +0800 From: "Lu, Wenzhuo" To: Jia Yu , "Ananyev, Konstantin" CC: "dev@dpdk.org" Thread-Topic: [PATCH] ixgbe: check scatter_enable in set_mtu Thread-Index: AQHSv51Mmuha9ekoS0a2DMvhzLkjr6HZ8uaA Date: Fri, 28 Apr 2017 00:49:18 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B59D683@shsmsx102.ccr.corp.intel.com> References: <1493327571-48435-1-git-send-email-jyu@vmware.com> In-Reply-To: <1493327571-48435-1-git-send-email-jyu@vmware.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ixgbe: check scatter_enable in set_mtu X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2017 00:49:24 -0000 Hi Jia, > -----Original Message----- > From: Jia Yu [mailto:jyu@vmware.com] > Sent: Friday, April 28, 2017 5:13 AM > To: Lu, Wenzhuo; Ananyev, Konstantin > Cc: dev@dpdk.org; Jia Yu > Subject: [PATCH] ixgbe: check scatter_enable in set_mtu >=20 > There exists case that software sets mtu (i.e jumbo frame) of ixgbe devic= e > when it's stopped. Before the fix, scattered_rx is cleared during device = stop, > and setting jumbo frame mtu after device stop will always fail as > scattered_rx is 0. > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) I'd like to ack this patch, but I found not sign-off. Would you like to sen= d a new version with sign-off? And you can add my ack in it.