From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 76C1B2935; Fri, 28 Apr 2017 09:20:29 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Apr 2017 00:20:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,387,1488873600"; d="scan'208";a="79950616" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 28 Apr 2017 00:20:27 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 28 Apr 2017 00:20:26 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 28 Apr 2017 00:20:26 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.117]) with mapi id 14.03.0319.002; Fri, 28 Apr 2017 15:20:24 +0800 From: "Lu, Wenzhuo" To: "Yang, Qiming" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH] igbvf: fix MAC address set problem Thread-Index: AQHSvzZ7bwHAGDpRoEGcKBezVkmzhKHZ8G4g///jYwCAAIyM0A== Date: Fri, 28 Apr 2017 07:20:24 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B59DA11@shsmsx102.ccr.corp.intel.com> References: <1493283743-71883-1-git-send-email-qiming.yang@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B59D627@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] igbvf: fix MAC address set problem X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2017 07:20:30 -0000 Hi Qiming, > -----Original Message----- > From: Yang, Qiming > Sent: Friday, April 28, 2017 2:54 PM > To: Lu, Wenzhuo; dev@dpdk.org > Cc: stable@dpdk.org > Subject: RE: [PATCH] igbvf: fix MAC address set problem >=20 > Hi, Wenzhuo >=20 > > -----Original Message----- > > From: Lu, Wenzhuo > > Sent: Friday, April 28, 2017 8:39 AM > > To: Yang, Qiming ; dev@dpdk.org > > Cc: stable@dpdk.org > > Subject: RE: [PATCH] igbvf: fix MAC address set problem > > > > Hi Qiming, > > > > > -----Original Message----- > > > From: Yang, Qiming > > > Sent: Thursday, April 27, 2017 5:02 PM > > > To: dev@dpdk.org > > > Cc: Lu, Wenzhuo; stable@dpdk.org; Yang, Qiming > > > Subject: [PATCH] igbvf: fix MAC address set problem > > > > > > We find that VF receive address register is not set if MAC address > > > is assigned by PF. This patch fixes it. > > > > > > Signed-off-by: Qiming Yang > > > > > > Fixes: 2a3cf07108b4 ("igbvf: fix MAC address if none assigned by > > > PF") > > A little confused about the Fixes. You said this patch is for when mac > > address is set by PF. But the fixes said the previous patch is for not > > set by PF. Seems they're different scenarios. Why this can a fix for a > different scenario? > > Thanks. >=20 > Previous patch only do rar set when random a MAC for VF, when MAC > address is assigned by PF, register is not set. > Maybe I should correct the fix line, the issue I fixed is exist before > 2a3cf07108b4. Better if you can find the previous patch :)