From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id E370A567F; Tue, 2 May 2017 03:21:38 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP; 01 May 2017 18:21:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,402,1488873600"; d="scan'208";a="1125457115" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 01 May 2017 18:21:37 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 1 May 2017 18:21:36 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 1 May 2017 18:21:36 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.224]) with mapi id 14.03.0319.002; Tue, 2 May 2017 09:21:33 +0800 From: "Lu, Wenzhuo" To: "Dai, Wei" , "thomas.monjalon@6wind.com" , "harish.patil@cavium.com" , "rasesh.mody@cavium.com" , "stephen.hurd@broadcom.com" , "ajit.khaparde@broadcom.com" , "Zhang, Helin" , "Ananyev, Konstantin" , "Wu, Jingjing" , "Chen, Jing D" , "adrien.mazarguil@6wind.com" , "nelio.laranjeiro@6wind.com" , "Richardson, Bruce" , "yuanhan.liu@linux.intel.com" , "maxime.coquelin@redhat.com" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v4 1/3] ethdev: fix adding invalid MAC addr Thread-Index: AQHStDAklJS27mQtNEO38qoCRcLcj6HPbAVAgAwDtQCABOx5IA== Date: Tue, 2 May 2017 01:21:32 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B59E5D7@shsmsx102.ccr.corp.intel.com> References: <1491987746-10155-1-git-send-email-wei.dai@intel.com> <6bc635ce8d902ca8b3c6d907a5622febea2f8157.1492071245.git.wei.dai@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B59B6C1@shsmsx102.ccr.corp.intel.com> <49759EB36A64CF4892C1AFEC9231E8D650A7836A@PGSMSX106.gar.corp.intel.com> In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D650A7836A@PGSMSX106.gar.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/3] ethdev: fix adding invalid MAC addr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 May 2017 01:21:39 -0000 Hi Wei, > -----Original Message----- > From: Dai, Wei > Sent: Saturday, April 29, 2017 2:09 PM > To: Lu, Wenzhuo; thomas.monjalon@6wind.com; harish.patil@cavium.com; > rasesh.mody@cavium.com; stephen.hurd@broadcom.com; > ajit.khaparde@broadcom.com; Zhang, Helin; Ananyev, Konstantin; Wu, > Jingjing; Chen, Jing D; adrien.mazarguil@6wind.com; > nelio.laranjeiro@6wind.com; Richardson, Bruce; > yuanhan.liu@linux.intel.com; maxime.coquelin@redhat.com > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH v4 1/3] ethdev: fix adding invalid MAC addr >=20 > HI, Wenzhuo >=20 > > > > > > int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int > > > wait_to_complete) diff --git a/drivers/net/e1000/base/e1000_api.c > > > b/drivers/net/e1000/base/e1000_api.c > > > index f7cf83b..dcb53f7 100644 > > > --- a/drivers/net/e1000/base/e1000_api.c > > > +++ b/drivers/net/e1000/base/e1000_api.c > > > @@ -855,7 +855,7 @@ int e1000_rar_set(struct e1000_hw *hw, u8 *addr, > > > u32 index) > > > if (hw->mac.ops.rar_set) > > > return hw->mac.ops.rar_set(hw, addr, index); > > > > > > - return E1000_SUCCESS; > > > + return E1000_ERR_NO_SPACE; > > > } > > NACK here. Normally we try to avoid changing base code. And I don't > > think the change is necessary. >=20 > If this code is not changed, the code in ethdev may get wrong return valu= e > and assume the failed MAC addr is added. > Anyway, we can ask the base code to be revised by the associated team. ' hw->mac.ops.rar_set ' cannot be NULL. That's why I think this change is n= ot necessary.