From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wenzhuo.lu@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id D98C47D2D
 for <dev@dpdk.org>; Fri,  5 May 2017 02:45:09 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 04 May 2017 17:45:08 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,290,1491289200"; d="scan'208";a="1143852618"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
 by fmsmga001.fm.intel.com with ESMTP; 04 May 2017 17:45:08 -0700
Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Thu, 4 May 2017 17:45:08 -0700
Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by
 fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Thu, 4 May 2017 17:45:08 -0700
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by
 SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0319.002;
 Fri, 5 May 2017 08:44:58 +0800
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, Thomas Monjalon
 <thomas@monjalon.net>, Shepard Siegel <shepard.siegel@atomicrules.com>, "Ed
 Czeck" <ed.czeck@atomicrules.com>, John Miller <john.miller@atomicrules.com>, 
 "Legacy, Allain (Wind River)" <allain.legacy@windriver.com>, "Peters, Matt
 (Wind River)" <matt.peters@windriver.com>, "Zhang, Helin"
 <helin.zhang@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>, Andrew Rybchenko
 <arybchenko@solarflare.com>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH] drivers/net: add generic ethdev macro to get PCI device
Thread-Index: AQHSxNeLnU4A3ynFh0GW1Tbz0wjShqHk50JQ
Date: Fri, 5 May 2017 00:44:57 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5A0963@shsmsx102.ccr.corp.intel.com>
References: <20170504130826.60701-1-ferruh.yigit@intel.com>
In-Reply-To: <20170504130826.60701-1-ferruh.yigit@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] drivers/net: add generic ethdev macro to get
	PCI device
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 05 May 2017 00:45:10 -0000

Hi,

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Thursday, May 4, 2017 9:08 PM
> To: Thomas Monjalon; Shepard Siegel; Ed Czeck; John Miller; Legacy, Allai=
n
> (Wind River); Peters, Matt (Wind River); Lu, Wenzhuo; Zhang, Helin; Wu,
> Jingjing; Ananyev, Konstantin; Andrew Rybchenko
> Cc: dev@dpdk.org; Yigit, Ferruh
> Subject: [PATCH] drivers/net: add generic ethdev macro to get PCI device
>=20
> Instead of many PMD define their own macro, define a generic one in ethde=
v
> and use that in PMDs.
>=20
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

BTW, there're RTE_DEV_TO_PCI(dev->device) in many places, maybe we can repl=
ace them by the new macro RTE_ETH_DEV_TO_PCI.