From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id E6AC42952; Tue, 9 May 2017 03:15:18 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 May 2017 18:15:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,311,1491289200"; d="scan'208";a="85113404" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 08 May 2017 18:15:16 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 8 May 2017 18:15:16 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 8 May 2017 18:15:16 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.217]) with mapi id 14.03.0319.002; Tue, 9 May 2017 09:15:14 +0800 From: "Lu, Wenzhuo" To: "Zhang, Qi Z" , "Zhang, Helin" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/ixgbe: fix LSC interrupt issue Thread-Index: AQHSx+rK/OopnzswdEKpiXimxPQujqHrM0nA Date: Tue, 9 May 2017 01:15:14 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5AABB1@SHSMSX103.ccr.corp.intel.com> References: <1494215853-3328-1-git-send-email-qi.z.zhang@intel.com> In-Reply-To: <1494215853-3328-1-git-send-email-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix LSC interrupt issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 May 2017 01:15:19 -0000 Hi Qi, > -----Original Message----- > From: Zhang, Qi Z > Sent: Monday, May 8, 2017 11:58 AM > To: Zhang, Helin; Lu, Wenzhuo > Cc: dev@dpdk.org; Zhang, Qi Z; stable@dpdk.org > Subject: [PATCH] net/ixgbe: fix LSC interrupt issue >=20 > There is a bug in previous fix for lsc interrupt. > lsc interrupt is not disabled before delayed handler, that cause the dela= yed > handler be re-entered. >=20 > Fixes: 9b667210700e ("net/ixgbe: fix blocked interrupts") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qi Zhang > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index ec667d8..c680aab 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -4107,14 +4107,15 @@ ixgbe_dev_interrupt_action(struct rte_eth_dev > *dev, > timeout =3D IXGBE_LINK_DOWN_CHECK_TIMEOUT; >=20 > ixgbe_dev_link_status_print(dev); > - intr->mask_original =3D intr->mask; > - /* only disable lsc interrupt */ > - intr->mask &=3D ~IXGBE_EIMS_LSC; > if (rte_eal_alarm_set(timeout * 1000, > ixgbe_dev_interrupt_delayed_handler, > (void *)dev) < 0) > PMD_DRV_LOG(ERR, "Error setting alarm"); > - else > - intr->mask =3D intr->mask_original; > + else { > + /* remember orignal mask */ Acked-by: Wenzhuo Lu Except orignal -> original