From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: Markus Theil <markus.theil@tu-ilmenau.de>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/igb: fix add/delete of flex filters
Date: Mon, 22 May 2017 01:51:01 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5BB2AE@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1495110014-20074-1-git-send-email-markus.theil@tu-ilmenau.de>
Hi Markus,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Markus Theil
> Sent: Thursday, May 18, 2017 8:20 PM
> To: dev@dpdk.org
> Cc: Markus Theil
> Subject: [dpdk-dev] [PATCH v2] net/igb: fix add/delete of flex filters
>
> Before this patch, flex_filter->index was always zero when it was read and
> used after rte_zmalloc. The corresponding code was therefore moved into
> the add and delete parts of the if/else statement. i210 and i211 also support
> flex filters.
Thanks for the patch. To my opinion, there're 2 things here. One is to support the flex filter on i210/i211. The other is to fix the index issue.
Would you like to split it to 2 patches? So you can add a fixes tag for the index one.
>
> Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>
> ---
> drivers/net/e1000/igb_ethdev.c | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
next prev parent reply other threads:[~2017-05-22 1:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 11:32 [dpdk-dev] [PATCH] " Markus Theil
2017-05-18 12:20 ` [dpdk-dev] [PATCH v2] " Markus Theil
2017-05-22 1:51 ` Lu, Wenzhuo [this message]
2017-05-22 10:17 ` [dpdk-dev] [PATCH v3 1/2] net/igb: support flex filters on i210/i211 Markus Theil
2017-05-22 10:17 ` [dpdk-dev] [PATCH v3 2/2] net/igb: fix add/delete of flex filters Markus Theil
2017-05-23 0:37 ` Lu, Wenzhuo
2017-05-23 0:36 ` [dpdk-dev] [PATCH v3 1/2] net/igb: support flex filters on i210/i211 Lu, Wenzhuo
2017-05-23 12:28 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09093B5BB2AE@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=markus.theil@tu-ilmenau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).