From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id E7FE523B for ; Mon, 22 May 2017 03:51:06 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP; 21 May 2017 18:51:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,377,1491289200"; d="scan'208";a="971454957" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 21 May 2017 18:51:05 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 21 May 2017 18:51:04 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 21 May 2017 18:51:04 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.193]) with mapi id 14.03.0319.002; Mon, 22 May 2017 09:51:02 +0800 From: "Lu, Wenzhuo" To: Markus Theil , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] net/igb: fix add/delete of flex filters Thread-Index: AQHSz9E9n1DCVmiIWUu33EdhUSecpKH/mUHA Date: Mon, 22 May 2017 01:51:01 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5BB2AE@shsmsx102.ccr.corp.intel.com> References: <1495107150-22206-1-git-send-email-markus.theil@tu-ilmenau.de> <1495110014-20074-1-git-send-email-markus.theil@tu-ilmenau.de> In-Reply-To: <1495110014-20074-1-git-send-email-markus.theil@tu-ilmenau.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/igb: fix add/delete of flex filters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 May 2017 01:51:07 -0000 Hi Markus, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Markus Theil > Sent: Thursday, May 18, 2017 8:20 PM > To: dev@dpdk.org > Cc: Markus Theil > Subject: [dpdk-dev] [PATCH v2] net/igb: fix add/delete of flex filters >=20 > Before this patch, flex_filter->index was always zero when it was read an= d > used after rte_zmalloc. The corresponding code was therefore moved into > the add and delete parts of the if/else statement. i210 and i211 also sup= port > flex filters. Thanks for the patch. To my opinion, there're 2 things here. One is to supp= ort the flex filter on i210/i211. The other is to fix the index issue. Would you like to split it to 2 patches? So you can add a fixes tag for the= index one.=20 >=20 > Signed-off-by: Markus Theil > --- > drivers/net/e1000/igb_ethdev.c | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-)