From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 025692C16 for ; Tue, 23 May 2017 07:53:23 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2017 22:53:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,380,1491289200"; d="scan'208";a="90530827" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 22 May 2017 22:53:21 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 22 May 2017 22:53:20 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 22 May 2017 22:53:20 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.246]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.193]) with mapi id 14.03.0319.002; Tue, 23 May 2017 13:53:18 +0800 From: "Lu, Wenzhuo" To: "Pattan, Reshma" , "Jastrzebski, MichalX K" , "dev@dpdk.org" CC: "Jain, Deepak K" , "Van Haaren, Harry" , "Azarewicz, PiotrX T" Thread-Topic: [PATCH 1/3] drivers/net: add support for IF-MIB and EtherLike-MIB for e1000 Thread-Index: AQHS0xlykDPM4GSJ10mTonNygVzBp6IBagaA Date: Tue, 23 May 2017 05:53:17 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5BBD53@shsmsx102.ccr.corp.intel.com> References: <20170522143202.22424-1-michalx.k.jastrzebski@intel.com> <20170522143202.22424-2-michalx.k.jastrzebski@intel.com> <3AEA2BF9852C6F48A459DA490692831F0113CF3E@irsmsx110.ger.corp.intel.com> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F0113CF3E@irsmsx110.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/3] drivers/net: add support for IF-MIB and EtherLike-MIB for e1000 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 May 2017 05:53:24 -0000 Hi Michal, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pattan, Reshma > Sent: Tuesday, May 23, 2017 12:35 AM > To: Jastrzebski, MichalX K; dev@dpdk.org > Cc: Jain, Deepak K; Van Haaren, Harry; Azarewicz, PiotrX T > Subject: Re: [dpdk-dev] [PATCH 1/3] drivers/net: add support for IF-MIB a= nd > EtherLike-MIB for e1000 >=20 > Hi, >=20 > Can you add the description to the commit message, describing what has > been done. >=20 > General doubt I have , I see all IF-MIB and Ether-Like-MIB attributes are > added as Xstats. > But most of IF-MIB attributes are not stats, instead they are informatio= n > about the interface/port. > So I guess such attributes should be displayed using separate method? > Everything being displayed as xstats might not be correct. The same question as Reshma. Seems most of the added parameters (if not all= ) are not stats.