From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wenzhuo.lu@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 2718D37B1
 for <dev@dpdk.org>; Thu,  1 Jun 2017 07:09:10 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga105.jf.intel.com with ESMTP; 31 May 2017 22:09:10 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.39,278,1493708400"; d="scan'208";a="1136802873"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
 by orsmga001.jf.intel.com with ESMTP; 31 May 2017 22:09:09 -0700
Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by
 fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Wed, 31 May 2017 22:09:09 -0700
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
 fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Wed, 31 May 2017 22:09:09 -0700
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by
 SHSMSX151.ccr.corp.intel.com ([169.254.3.56]) with mapi id 14.03.0319.002;
 Thu, 1 Jun 2017 13:09:06 +0800
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "Zhang, Helin"
 <helin.zhang@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH 1/3] net/ixgbe: replace macro with inline function
Thread-Index: AQHS1pU6YL30xW+kwEKUyTHf0SI0UqIPfFMA
Date: Thu, 1 Jun 2017 05:09:05 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5C98B0@shsmsx102.ccr.corp.intel.com>
References: <1495828350-10259-1-git-send-email-qi.z.zhang@intel.com>
 <1495828350-10259-2-git-send-email-qi.z.zhang@intel.com>
In-Reply-To: <1495828350-10259-2-git-send-email-qi.z.zhang@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 1/3] net/ixgbe: replace macro with inline
	function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Jun 2017 05:09:11 -0000

Hi Qi,


> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Saturday, May 27, 2017 3:52 AM
> To: Zhang, Helin; Lu, Wenzhuo
> Cc: dev@dpdk.org; Zhang, Qi Z
> Subject: [PATCH 1/3] net/ixgbe: replace macro with inline function
>=20
> Code clean, replace macro with inline funtion for searching next no void
> pattern and next no void action
>=20
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
>  drivers/net/ixgbe/ixgbe_flow.c | 208 +++++++++++++++--------------------=
------
>  1 file changed, 73 insertions(+), 135 deletions(-)
This patch is good, but don't understand the necessity to replace the macro=
. Would you like to add more explanation in the commit log?