From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C00765688 for ; Thu, 1 Jun 2017 08:15:57 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 May 2017 23:15:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,278,1493708400"; d="scan'208";a="109033882" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 31 May 2017 23:15:53 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 31 May 2017 23:15:53 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 31 May 2017 23:15:52 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0319.002; Thu, 1 Jun 2017 14:15:51 +0800 From: "Lu, Wenzhuo" To: "Zhang, Qi Z" , "Zhang, Helin" CC: "dev@dpdk.org" Thread-Topic: [PATCH 3/3] net/ixgbe: enable IPv6 for consistent API Thread-Index: AQHS1pU9ywFKC0i7DE65RijAxD+DraIPj02w Date: Thu, 1 Jun 2017 06:15:51 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5C9A96@shsmsx102.ccr.corp.intel.com> References: <1495828350-10259-1-git-send-email-qi.z.zhang@intel.com> <1495828350-10259-4-git-send-email-qi.z.zhang@intel.com> In-Reply-To: <1495828350-10259-4-git-send-email-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/3] net/ixgbe: enable IPv6 for consistent API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2017 06:15:58 -0000 Hi Qi, > -----Original Message----- > From: Zhang, Qi Z > Sent: Saturday, May 27, 2017 3:53 AM > To: Zhang, Helin; Lu, Wenzhuo > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH 3/3] net/ixgbe: enable IPv6 for consistent API >=20 > Enable IPv6 support with rte_flow API. > Only support Sigature Match. >=20 > Signed-off-by: Qi Zhang > --- > drivers/net/ixgbe/ixgbe_flow.c | 112 > ++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 104 insertions(+), 8 deletions(-) > /* Get the TCP info. */ > if (item->type =3D=3D RTE_FLOW_ITEM_TYPE_TCP) { > /** > * Set the flow type even if there's no content > * as we must have a flow type. > */ > - rule->ixgbe_fdir.formatted.flow_type =3D > + rule->ixgbe_fdir.formatted.flow_type |=3D > IXGBE_ATR_FLOW_TYPE_TCPV4; This macro is misleading, better change it to IXGBE_ATR_L4TYPE_TCP. > /*Not supported last point for range*/ > if (item->last) { > @@ -1715,7 +1811,7 @@ ixgbe_parse_fdir_filter_normal(const struct > rte_flow_attr *attr, > * Set the flow type even if there's no content > * as we must have a flow type. > */ > - rule->ixgbe_fdir.formatted.flow_type =3D > + rule->ixgbe_fdir.formatted.flow_type |=3D > IXGBE_ATR_FLOW_TYPE_UDPV4; IXGBE_ATR_L4TYPE_UDP is better. > /*Not supported last point for range*/ > if (item->last) { > @@ -1775,7 +1871,7 @@ ixgbe_parse_fdir_filter_normal(const struct > rte_flow_attr *attr, > * Set the flow type even if there's no content > * as we must have a flow type. > */ > - rule->ixgbe_fdir.formatted.flow_type =3D > + rule->ixgbe_fdir.formatted.flow_type |=3D > IXGBE_ATR_FLOW_TYPE_SCTPV4; IXGBE_ATR_L4TYPE_SCTP is better. > /*Not supported last point for range*/ > if (item->last) { > -- > 2.7.4