From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 531BA2B91 for ; Wed, 7 Jun 2017 08:13:28 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jun 2017 23:13:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,309,1493708400"; d="scan'208";a="865373331" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 06 Jun 2017 23:13:21 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 6 Jun 2017 23:13:15 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.56]) with mapi id 14.03.0319.002; Wed, 7 Jun 2017 14:12:05 +0800 From: "Lu, Wenzhuo" To: "Xing, Beilei" , "Wu, Jingjing" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 2/2] net/i40e: add NVGRE parsing function Thread-Index: AQHS2qTxtltW4KhUUEOJTYnmI5tft6IY6w1Q//+CB4CAAIatkA== Date: Wed, 7 Jun 2017 06:12:05 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5CCBCD@shsmsx102.ccr.corp.intel.com> References: <1495099241-20103-1-git-send-email-beilei.xing@intel.com> <1496300191-137516-1-git-send-email-beilei.xing@intel.com> <1496300191-137516-3-git-send-email-beilei.xing@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B5CCBA8@shsmsx102.ccr.corp.intel.com> <94479800C636CB44BD422CB454846E0131FC3969@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <94479800C636CB44BD422CB454846E0131FC3969@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: add NVGRE parsing function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jun 2017 06:13:31 -0000 > -----Original Message----- > From: Xing, Beilei > Sent: Wednesday, June 7, 2017 2:07 PM > To: Lu, Wenzhuo; Wu, Jingjing > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 2/2] net/i40e: add NVGRE parsing functi= on >=20 >=20 >=20 > > -----Original Message----- > > From: Lu, Wenzhuo > > Sent: Wednesday, June 7, 2017 1:46 PM > > To: Xing, Beilei ; Wu, Jingjing > > > > Cc: dev@dpdk.org > > Subject: RE: [dpdk-dev] [PATCH v2 2/2] net/i40e: add NVGRE parsing > > function > > > > Hi Beilei, > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing > > > Sent: Thursday, June 1, 2017 2:57 PM > > > To: Wu, Jingjing > > > Cc: dev@dpdk.org > > > Subject: [dpdk-dev] [PATCH v2 2/2] net/i40e: add NVGRE parsing > > > function > > > > > > This patch adds NVGRE parsing function to support NVGRE classificatio= n. > > > > > > Signed-off-by: Beilei Xing > > > --- > > > drivers/net/i40e/i40e_flow.c | 271 > > > ++++++++++++++++++++++++++++++++++++++++++- > > > 1 file changed, 269 insertions(+), 2 deletions(-) >=20 > > > > > + > > > + break; > > > + case RTE_FLOW_ITEM_TYPE_VLAN: > > > + vlan_spec =3D > > > + (const struct rte_flow_item_vlan *)item- > > > >spec; > > > + vlan_mask =3D > > > + (const struct rte_flow_item_vlan *)item- > > > >mask; > > > + if (nvgre_flag) { > > Why need to check nvgre_flag? Seems VLAN must be after NVGRE, so this > > flag is always 1. >=20 > It's used to distinguish outer mac or inner mac. I know you need to add this flag for MAC. But I'm talking about VLAN. There= 's only inner VLAN. So, seems it's useless here.