From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id BB7331F5 for ; Wed, 26 Jul 2017 16:58:12 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jul 2017 07:58:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,415,1496127600"; d="scan'208";a="883048286" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 26 Jul 2017 07:58:11 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 26 Jul 2017 07:58:11 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.197]) with mapi id 14.03.0319.002; Wed, 26 Jul 2017 22:58:08 +0800 From: "Lu, Wenzhuo" To: "Wiles, Keith" , Thomas Monjalon CC: DPDK , "Dumitrescu, Cristian" Thread-Topic: hierarchy_commit() message displayed when not using TM Thread-Index: AQHTBhxoVyAWRtvo30mm3P//qiNEaKJmMsPw Date: Wed, 26 Jul 2017 14:58:08 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B67CCD0@shsmsx102.ccr.corp.intel.com> References: <20170725222107.23203-1-thomas@monjalon.net> <4FFF6FD7-FAAB-4034-92DC-D1CF27294837@intel.com> <5680989.RRpAUyPcSC@xps> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTJlY2NiNDktYjg1OS00MTFhLTg5MmItYmY0OTZmMGM2ZTMwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InlXN1NBVG1Va3duNkp0OFdEcEZkNVU4WmRPTENwVjFnUm1OVk85cWxQMWM9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] hierarchy_commit() message displayed when not using TM X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jul 2017 14:58:13 -0000 Hi Keith, Thomas, > -----Original Message----- > From: Wiles, Keith > Sent: Wednesday, July 26, 2017 10:35 AM > To: Thomas Monjalon > Cc: DPDK ; Dumitrescu, Cristian > ; Lu, Wenzhuo > Subject: hierarchy_commit() message displayed when not using TM >=20 >=20 > > On Jul 26, 2017, at 12:39 AM, Thomas Monjalon > wrote: > > > >> I noticed a new message: > >> i40e_dev_start(): please call hierarchy_commit() before starting the p= ort > >> i40e_dev_start(): please call hierarchy_commit() before starting the p= ort > >> i40e_dev_start(): please call hierarchy_commit() before starting the p= ort > >> i40e_dev_start(): please call hierarchy_commit() before starting the p= ort > >> > >> and I tried to add the call in pktgen, but it had no effect. To me the= TM API > should be defaulted to the original mode and just work unless someone > needs to use the TM APIs. The hierarchy_commit routine could not need to > be called in the normal case is my guess. > > > > PS: I've noticed that you are the author of all the pktgen commits. > > Are you using git-am when applying patches from other contributors? >=20 > Cristian and Wenzhuo responded in another email and the messages above > will be fixed. Just FYI, I've sent the patches to fix it. >=20 > Regards, > Keith