Re: [dpdk-dev] [PATCH v4] net/ixgbe: add support of 2.5G and 5G on X550

["Lu, Wenzhuo" <wenzhuo.lu@intel.com>]

Hi Wei,

> -----Original Message-----
> From: Dai, Wei
> Sent: Wednesday, July 26, 2017 11:30 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>
> Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>
> Subject: [PATCH v4] net/ixgbe: add support of 2.5G and 5G on X550
> 
> This patch adds support of 2.5G and 5G ethernet interface on X550.
> 
> Signed-off-by: Wei Dai <wei.dai@intel.com>
> ---
>  drivers/net/ixgbe/base/ixgbe_type.h |  5 +++++
>  drivers/net/ixgbe/ixgbe_ethdev.c    | 27 ++++++++++++++++++++++++---
>  2 files changed, 29 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ixgbe/base/ixgbe_type.h
> b/drivers/net/ixgbe/base/ixgbe_type.h
> index bda8558..3fd5425 100644
> --- a/drivers/net/ixgbe/base/ixgbe_type.h
> +++ b/drivers/net/ixgbe/base/ixgbe_type.h
> @@ -3408,6 +3408,11 @@ typedef u32 ixgbe_link_speed;
>  #define IXGBE_LINK_SPEED_82599_AUTONEG
> 	(IXGBE_LINK_SPEED_100_FULL | \
>  					 IXGBE_LINK_SPEED_1GB_FULL | \
>  					 IXGBE_LINK_SPEED_10GB_FULL)
> +#define IXGBE_LINK_SPEED_X550_AUTONEG
> 	(IXGBE_LINK_SPEED_100_FULL | \
> +					IXGBE_LINK_SPEED_1GB_FULL | \
> +					IXGBE_LINK_SPEED_2_5GB_FULL | \
> +					IXGBE_LINK_SPEED_5GB_FULL | \
> +					IXGBE_LINK_SPEED_10GB_FULL)
Just noticed you changed base code. As we discussed before, I don't mean that. Actually, I suggest to put it in, for example, ixgbe_ethdev.h