From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <wenzhuo.lu@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
by dpdk.org (Postfix) with ESMTP id F246A101B
for <dev@dpdk.org>; Mon, 25 Sep 2017 03:58:40 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
by orsmga104.jf.intel.com with ESMTP; 24 Sep 2017 18:58:39 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,434,1500966000"; d="scan'208";a="903455078"
Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204])
by FMSMGA003.fm.intel.com with ESMTP; 24 Sep 2017 18:58:39 -0700
Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by
FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS)
id 14.3.319.2; Sun, 24 Sep 2017 18:58:39 -0700
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by
SHSMSX104.ccr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0319.002;
Mon, 25 Sep 2017 09:58:38 +0800
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Singh, Jasvinder" <jasvinder.singh@intel.com>, "dev@dpdk.org"
<dev@dpdk.org>
CC: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>, "Yigit, Ferruh"
<ferruh.yigit@intel.com>, "thomas@monjalon.net" <thomas@monjalon.net>
Thread-Topic: [dpdk-dev] [PATCH v4 2/4] net/softnic: add traffic management
support
Thread-Index: AQHTMFxhEOo9UotNBkSy8/x5tcNqo6LE3qxA
Date: Mon, 25 Sep 2017 01:58:37 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B6BD0F3@shsmsx102.ccr.corp.intel.com>
References: <20170811124929.118564-2-jasvinder.singh@intel.com>
<20170918091015.82824-1-jasvinder.singh@intel.com>
<20170918091015.82824-3-jasvinder.singh@intel.com>
In-Reply-To: <20170918091015.82824-3-jasvinder.singh@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v4 2/4] net/softnic: add traffic
management support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Sep 2017 01:58:41 -0000
Hi Jasvinder,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jasvinder Singh
> Sent: Monday, September 18, 2017 5:10 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; thomas@monjalon.net
> Subject: [dpdk-dev] [PATCH v4 2/4] net/softnic: add traffic management
> support
>=20
> Add ethdev Traffic Management API support to SoftNIC PMD.
>=20
> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
> v3 changes:
> - add more confguration parameters (tm rate, tm queue sizes)
>=20
> drivers/net/softnic/Makefile | 1 +
> drivers/net/softnic/rte_eth_softnic.c | 252
> +++++++++++++++++++++++-
> drivers/net/softnic/rte_eth_softnic.h | 16 ++
> drivers/net/softnic/rte_eth_softnic_internals.h | 106 +++++++++-
> drivers/net/softnic/rte_eth_softnic_tm.c | 181 +++++++++++++++++
> 5 files changed, 553 insertions(+), 3 deletions(-) create mode 100644
> drivers/net/softnic/rte_eth_softnic_tm.c
>=20
> static void
> @@ -293,6 +325,77 @@ rte_pmd_softnic_run_default(struct rte_eth_dev
> *dev)
> return 0;
> }
>=20
> +static __rte_always_inline int
> +rte_pmd_softnic_run_tm(struct rte_eth_dev *dev) {
This function name seems a little misleading. If it's a inline function not=
an API, better just name it 'softnic_run_tm".
And a common comments for the names, like, pmd_feature, tm_params_check, tm=
_init ... if they're only for soft nic, better add the prefix 'softnc_' for=
them.