From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <wenzhuo.lu@intel.com> Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 2C5BD23A for <dev@dpdk.org>; Mon, 25 Sep 2017 04:34:23 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2017 19:34:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,434,1500966000"; d="scan'208";a="1017967296" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 24 Sep 2017 19:34:21 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 24 Sep 2017 19:34:21 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 24 Sep 2017 19:34:21 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Mon, 25 Sep 2017 10:33:20 +0800 From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com> To: "Singh, Jasvinder" <jasvinder.singh@intel.com>, "dev@dpdk.org" <dev@dpdk.org> CC: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, "thomas@monjalon.net" <thomas@monjalon.net> Thread-Topic: [dpdk-dev] [PATCH v4 3/4] net/softnic: add TM capabilities ops Thread-Index: AQHTMFxkmpm8lGDHnkO4orlKJXTxiaLE7AAw Date: Mon, 25 Sep 2017 02:33:19 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B6BD155@shsmsx102.ccr.corp.intel.com> References: <20170811124929.118564-2-jasvinder.singh@intel.com> <20170918091015.82824-1-jasvinder.singh@intel.com> <20170918091015.82824-4-jasvinder.singh@intel.com> In-Reply-To: <20170918091015.82824-4-jasvinder.singh@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 3/4] net/softnic: add TM capabilities ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 25 Sep 2017 02:34:23 -0000 Hi Jasvinder, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jasvinder Singh > Sent: Monday, September 18, 2017 5:10 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Yigit, Ferruh > <ferruh.yigit@intel.com>; thomas@monjalon.net > Subject: [dpdk-dev] [PATCH v4 3/4] net/softnic: add TM capabilities ops >=20 > Implement ethdev TM capability APIs in SoftNIC PMD. >=20 > Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com> > --- > drivers/net/softnic/rte_eth_softnic.c | 12 +- > drivers/net/softnic/rte_eth_softnic_internals.h | 32 ++ > drivers/net/softnic/rte_eth_softnic_tm.c | 500 > ++++++++++++++++++++++++ > 3 files changed, 543 insertions(+), 1 deletion(-) The same concern of the naming as patch 2.The function and structure names = are too common. Better add the prefix 'softnic_' too. Except that, the patch looks good to me.