From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wenzhuo.lu@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 1F0E41B338
 for <dev@dpdk.org>; Mon, 16 Oct 2017 02:43:58 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by fmsmga105.fm.intel.com with ESMTP; 15 Oct 2017 17:43:57 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,384,1503385200"; d="scan'208";a="138744723"
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
 by orsmga004.jf.intel.com with ESMTP; 15 Oct 2017 17:43:57 -0700
Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by
 FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Sun, 15 Oct 2017 17:43:56 -0700
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
 fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Sun, 15 Oct 2017 17:43:56 -0700
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by
 SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002;
 Mon, 16 Oct 2017 08:43:54 +0800
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: Roger B Melton <rmelton@cisco.com>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH v2] net/e1000: correct VLAN tag byte order for i35x LB
 packets
Thread-Index: AQHTQ38ILXAjQbAsU0qvP9rWyBdLx6LlqF0g
Date: Mon, 16 Oct 2017 00:43:54 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B6D1EA1@shsmsx102.ccr.corp.intel.com>
References: <20171012172435.34700-1-rmelton@cisco.com>
In-Reply-To: <20171012172435.34700-1-rmelton@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2] net/e1000: correct VLAN tag byte order
 for i35x LB packets
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Oct 2017 00:43:59 -0000

Hi,

> -----Original Message-----
> From: Roger B Melton [mailto:rmelton@cisco.com]
> Sent: Friday, October 13, 2017 1:25 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Roger B Melton <rmelton@cisco.com>
> Subject: [PATCH v2] net/e1000: correct VLAN tag byte order for i35x LB
> packets
>=20
> When copying VLAN tags from the RX descriptor to the vlan_tci field in th=
e
> mbuf header,  igb_rxtx.c:eth_igb_recv_pkts() and
> eth_igb_recv_scattered_pkts() both assume that the VLAN tag is always lit=
tle
> endian.  While i350, i354 and /i350vf VLAN non-loopback packets are store=
d
> little endian, VLAN tags in loopback packets for those devices are big en=
dian.
>=20
> For i350, i354 and i350vf VLAN loopback packets, swap the tag when copyin=
g
> from the RX descriptor to the mbuf header.  This will ensure that the mbu=
f
> vlan_tci is always little endian.
>=20
> Signed-off-by: Roger B Melton <rmelton@cisco.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>