From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id C5BA71B70C for ; Tue, 24 Oct 2017 02:31:15 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP; 23 Oct 2017 17:31:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,424,1503385200"; d="scan'208";a="1234368040" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 23 Oct 2017 17:31:14 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 23 Oct 2017 17:31:14 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 23 Oct 2017 17:31:14 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0319.002; Tue, 24 Oct 2017 08:31:12 +0800 From: "Lu, Wenzhuo" To: "Mcnamara, John" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] doc: how to set VF MAC address on ixgbe Thread-Index: AQHTS8DwhX/dcqdsoUeLOmzRD9TXwaLw1rMAgAFQcBA= Date: Tue, 24 Oct 2017 00:31:12 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B6D8C9D@shsmsx102.ccr.corp.intel.com> References: <1508737092-37275-1-git-send-email-wenzhuo.lu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: how to set VF MAC address on ixgbe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 00:31:16 -0000 Hi John, > -----Original Message----- > From: Mcnamara, John > Sent: Monday, October 23, 2017 8:27 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH] doc: how to set VF MAC address on ixgbe >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > > Sent: Monday, October 23, 2017 6:38 AM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo > > Subject: [dpdk-dev] [PATCH] doc: how to set VF MAC address on ixgbe > > > > Add the description of how to add a MAC address for a VF from PF on > ixgbe. > > > > Signed-off-by: Wenzhuo Lu > > --- > > doc/guides/nics/ixgbe.rst | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ixgbe.rst > > index > > 696ff69..bd0dc68 100644 > > --- a/doc/guides/nics/ixgbe.rst > > +++ b/doc/guides/nics/ixgbe.rst > > @@ -227,6 +227,17 @@ So when the user sets different MTUs on PF and > VF > > ports in one physical port, the real MTU for all these PF and VF > > ports is the largest value set. > > This behavior is based on the kernel driver behavior. > > > > +VF MAC address setting > > +~~~~~~~~~~~~~~~~~~~~~~ > > + > > +On ixgbe, the concept pool can be used for different things. It > > +depends on the mode. In VMDq mode, the pool means a VMDq pool. In > IOV > > +mode, the pool means a VF. > > +When setting the parameters of a pool, in VMDq mode, it's for a VMDq > > +pool, in IOV mode, it's for a VF. > > +There's no RTE API to add a VF's MAC address from PF. On ixgbe, > > +there's a workaround to do it. "rte_eth_dev_mac_addr_add" also can be > > +used to add a VF's MAC address. >=20 > I'd suggest something like the following may be a bit clearer: >=20 > VF MAC address setting > ~~~~~~~~~~~~~~~~~~~~~~ >=20 > On ixgbe, the concept of "pool" can be used for different things dependin= g > on the mode. In VMDq mode, "pool" means a VMDq pool. In IOV mode, > "pool" means a VF. >=20 > There is no RTE API to add a VF's MAC address from the PF. On ixgbe, the > ``rte_eth_dev_mac_addr_add()`` function can be can be used to add a VF's > MAC address, as a workaround. >=20 Thanks for the suggestion. I'll send a V2.