From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 42D187D19 for ; Tue, 9 Jan 2018 02:35:25 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2018 17:35:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,333,1511856000"; d="scan'208";a="165222816" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga004.jf.intel.com with ESMTP; 08 Jan 2018 17:35:23 -0800 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 8 Jan 2018 17:35:23 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 8 Jan 2018 17:35:23 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.189]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Tue, 9 Jan 2018 09:35:21 +0800 From: "Lu, Wenzhuo" To: Stephen Hemminger CC: "dev@dpdk.org" , "Wu, Jingjing" Thread-Topic: [dpdk-dev] [PATCH v4 01/15] net/avf/base: add base code for avf PMD Thread-Index: AQHThf37QonUq6oOeESrMCmZQf8MKKNlNKoAgAP3A3CAAGyoAIABL4AA Date: Tue, 9 Jan 2018 01:35:20 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B70B51A@shsmsx102.ccr.corp.intel.com> References: <1511505206-97333-1-git-send-email-jingjing.wu@intel.com> <1515140505-38655-1-git-send-email-wenzhuo.lu@intel.com> <1515140505-38655-2-git-send-email-wenzhuo.lu@intel.com> <20180105122552.70da9a37@xeon-e3> <6A0DE07E22DDAD4C9103DF62FEBC09093B70A8E8@shsmsx102.ccr.corp.intel.com> <20180108072738.6250adfd@xeon-e3> In-Reply-To: <20180108072738.6250adfd@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 01/15] net/avf/base: add base code for avf PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 01:35:25 -0000 Hi Stephen, > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Monday, January 8, 2018 11:28 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Wu, Jingjing > Subject: Re: [dpdk-dev] [PATCH v4 01/15] net/avf/base: add base code for = avf > PMD >=20 > On Mon, 8 Jan 2018 01:06:36 +0000 > "Lu, Wenzhuo" wrote: >=20 > > > This function is way to big to be an inline. > > Thanks for your comments. Let me explain. This is the base code, like > what's in ixgbe, i40e ... We have to let it be so it's much easier for us= to > update it the next time. That's why the code style is a little different.= And > also some checkpatch problem not handled. > > We have had some discussion about the copyright license here and > internally. But unfortunately we don't achieve a conclusion internally so= we > have to keep the long license now and may change it later. >=20 >=20 > If you have to have base code then put it in a subdirectory base/ that wa= y > reviewers and maintainers can separate DPDK part from ugly stuff. Yes, that's we've done. And we also use an individual patch for it :)