From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 7E4EE1322C for ; Tue, 9 Jan 2018 07:30:07 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2018 22:30:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,334,1511856000"; d="scan'208";a="19440978" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 08 Jan 2018 22:30:05 -0800 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 8 Jan 2018 22:30:05 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 8 Jan 2018 22:30:04 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.189]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.213]) with mapi id 14.03.0319.002; Tue, 9 Jan 2018 14:30:03 +0800 From: "Lu, Wenzhuo" To: Shahaf Shuler , "Wu, Jingjing" , "Yigit, Ferruh" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 06/10] app/testpmd: cleanup internal Tx offloads flags field Thread-Index: AQHTfi5qyz//zCPZ4USKwvNkRsk0xqNrKbIw Date: Tue, 9 Jan 2018 06:30:01 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B70C4D2@shsmsx102.ccr.corp.intel.com> References: <11e9149de883871295c9b9ad069af5fee0cd64b2.1514281260.git.shahafs@mellanox.com> In-Reply-To: <11e9149de883871295c9b9ad069af5fee0cd64b2.1514281260.git.shahafs@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 06/10] app/testpmd: cleanup internal Tx offloads flags field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 06:30:08 -0000 Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Tuesday, December 26, 2017 5:44 PM > To: Wu, Jingjing ; Yigit, Ferruh > > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 06/10] app/testpmd: cleanup internal Tx > offloads flags field >=20 > The tx_ol_flags field was used in order to control the different Tx offlo= ads > set. After the conversion to the new Ethdev Tx offloads API it is not nee= ded > anymore as the offloads configuration is stored in ethdev structs. >=20 > Signed-off-by: Shahaf Shuler > --- > app/test-pmd/cmdline.c | 49 ++++++++++++++++---------------------------= - > app/test-pmd/config.c | 4 ---- > app/test-pmd/csumonly.c | 40 ++++++++++++++++++------------------ > app/test-pmd/flowgen.c | 8 +++++--- > app/test-pmd/macfwd.c | 8 +++++--- > app/test-pmd/macswap.c | 8 +++++--- > app/test-pmd/testpmd.h | 22 +------------------- > app/test-pmd/txonly.c | 8 +++++--- > 8 files changed, 59 insertions(+), 88 deletions(-) >=20 > +195,7 @@ struct rte_port { > struct fwd_stream *rx_stream; /**< Port RX stream, if unique */ > struct fwd_stream *tx_stream; /**< Port TX stream, if unique */ > unsigned int socket_id; /**< For NUMA support */ > - uint16_t tx_ol_flags;/**< TX Offload Flags > (TESTPMD_TX_OFFLOAD...). */ > + uint16_t parse_tunnel:1; /**< Parse internal headers This flag looks a little incongruous here, but anyway we have to have it. Acked-by: Wenzhuo Lu