From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 7515C1B01E for ; Tue, 9 Jan 2018 08:48:22 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2018 23:48:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,334,1511856000"; d="scan'208";a="9783197" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga006.jf.intel.com with ESMTP; 08 Jan 2018 23:48:20 -0800 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 8 Jan 2018 23:48:19 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 8 Jan 2018 23:48:19 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.189]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Tue, 9 Jan 2018 15:48:18 +0800 From: "Lu, Wenzhuo" To: Shahaf Shuler , "Wu, Jingjing" , "Yigit, Ferruh" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 09/10] app/testpmd: enforce offloads caps Thread-Index: AQHTfi6IXfrFxxe4IUejgB69XTQiyKNrP++g Date: Tue, 9 Jan 2018 07:48:16 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B70C59F@shsmsx102.ccr.corp.intel.com> References: <3753b04124e07a00c8d45dc8b792f46dd4e21224.1514281260.git.shahafs@mellanox.com> In-Reply-To: <3753b04124e07a00c8d45dc8b792f46dd4e21224.1514281260.git.shahafs@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 09/10] app/testpmd: enforce offloads caps X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 07:48:22 -0000 Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Tuesday, December 26, 2017 5:44 PM > To: Wu, Jingjing ; Yigit, Ferruh > > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 09/10] app/testpmd: enforce offloads caps >=20 > In the current design it was possible for offload to be set even though t= he > device is not supporting it. A warning message was printed instead. >=20 > This is a wrong behaviour, as application should set only the offloads > reported by the capabilities of the device. >=20 > This patch adds verification for the offloads being set and make sure the > offload configuration passed to the device always match its capabilities. >=20 > Signed-off-by: Shahaf Shuler Acked-by: Wenzhuo Lu