From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 58F8C1B00B for ; Tue, 9 Jan 2018 09:06:03 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2018 00:06:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,334,1511856000"; d="scan'208";a="193482744" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 09 Jan 2018 00:06:02 -0800 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Jan 2018 00:06:02 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Jan 2018 00:06:01 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.189]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Tue, 9 Jan 2018 16:05:59 +0800 From: "Lu, Wenzhuo" To: Shahaf Shuler , "Wu, Jingjing" , "Yigit, Ferruh" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 10/10] app/testpmd: fix on the flight VLAN configuration Thread-Index: AQHTfi6Vi7NpD7XKIEWkyN9MCkzJTqNrQSuA Date: Tue, 9 Jan 2018 08:05:58 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B70C5D9@shsmsx102.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 10/10] app/testpmd: fix on the flight VLAN configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 08:06:03 -0000 Hi Shahaf, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Tuesday, December 26, 2017 5:44 PM > To: Wu, Jingjing ; Yigit, Ferruh > > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 10/10] app/testpmd: fix on the flight VLAN > configuration >=20 > On ethdev there is an API to configure VLAN offloads after the port was > started and without reconfiguration of the port or queues. >=20 > In the current design of the application, when the Rx offloads are change= d > (through "port config all" CLI command) the port configuration is overwri= tten, > therefore the configuration made for the VLAN is lost. >=20 > This patch is to address the issue by a configuration of each port Rx off= loads > separately instead of using the global Rx config. >=20 > Fixes: 6dbb2b336586 ("app/testpmd: convert to new Ethdev Rx offloads API"= ) This patch is not applied yet. The number 6dbb2b336586 could be meaningless= . If the previous patch need to be fixed, may I suggest just merge this one= to that? Or this patch fixes some older issues actually?