From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 0BDEA3772 for ; Tue, 9 Jan 2018 12:37:11 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2018 03:37:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,335,1511856000"; d="scan'208";a="22590693" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 09 Jan 2018 03:37:10 -0800 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Jan 2018 03:37:10 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 9 Jan 2018 03:37:09 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.189]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Tue, 9 Jan 2018 19:37:08 +0800 From: "Lu, Wenzhuo" To: Shahaf Shuler , "Wu, Jingjing" , "Yigit, Ferruh" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 04/10] app/testpmd: convert to new Ethdev Tx offloads API Thread-Index: AQHTfi5U+ewllJ8umUG0NKuYsrNbl6NrFnag//+SlgCAAIyMsP//qdEAgACeljA= Date: Tue, 9 Jan 2018 11:37:07 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B70C9CA@shsmsx102.ccr.corp.intel.com> References: <6A0DE07E22DDAD4C9103DF62FEBC09093B70C42F@shsmsx102.ccr.corp.intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B70C530@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmRkNDJlMTYtOWFhNy00MDJmLWE3MGEtZWJlMDY0MTBkMzBiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjYzN21GVEp3OEl5OTZNWlR3WFBFcmtING9oQWZWQVhib1FpK2VBem9zQU09In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 04/10] app/testpmd: convert to new Ethdev Tx offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 11:37:12 -0000 Hi Shahaf, > -----Original Message----- > From: Shahaf Shuler [mailto:shahafs@mellanox.com] > Sent: Tuesday, January 9, 2018 6:02 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Yigit, Ferruh > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3 04/10] app/testpmd: convert to new > Ethdev Tx offloads API >=20 > Tuesday, January 9, 2018 9:14 AM, Lu, Wenzhuo: > > > The original code doesn't have such restriction because testpmd > > > wasn't configuring Tx offloads at all. It used it's own Tx offloads > > > enum (which I removed on later patches) to indicate which offloads is= set. > > > From the device perspective all the Tx offloads should be set. > > > It did had a way to configure offloads with txqflags parameter, but > > > this required queues reconfigurations. > > ' cmd_tx_vlan_set_parsed' is the function which configures TX vlan > insertion. > > This patch adds the restriction in it. > > For example, on ixgbe it does support on the fly configuration. APP > > doesn't need to stop the device or reconfigure the queues. >=20 > What is mean is that in the old offloads API, all the Tx offloads were en= abled > by default, besides the ones which were masked with txqflags. > This is why testpmd didn't have any limitation on changing the Tx offload= s. > All of them were enabled, it just needed to choose with which one to use. >=20 > Now, with the new offloads API, the Tx offloads are disabled by default, = and > enabled per application need on device and queue configuration. > In order to call device/queue configuration the port must be stopped. Thi= s is > requirement from ethdev API. >=20 > Now, there is an API in ethdev to configure Rx VLAN offloads on the fligh= t for > supported devices. > If there are devices which supports it also in the Tx side, and you see a= good > use case for that, then need to think of new API in ethdev to configure T= x > VLAN offloads on the flight. >=20 > However, the plain conversion of testpmd from the old to the new API > requires the port to be stopped for all of the Tx offloads. Let's just talk about TX vlan insertion. Actually there's no ethdev API for= it. And no configuration for it. Because vlan insertion is simple, it only= need to add a vlan tag when transmitting packets. You can see it's per packet thing. APP can set the ol_flags and vlan_tci in= the mbuf of every packet to enable this function for the packet or not. I = think it does be a on the fly function on any NIC.