From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Xueming(Steven) Li" <xuemingl@mellanox.com>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Olivier MATZ <olivier.matz@6wind.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] app/testpmd: support command echo in CLI batch loading
Date: Wed, 10 Jan 2018 12:25:34 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B70DC7C@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <VI1PR05MB1678AA5B8ABEB1815F21BCFFAC110@VI1PR05MB1678.eurprd05.prod.outlook.com>
Hi Xueming,
> -----Original Message-----
> From: Xueming(Steven) Li [mailto:xuemingl@mellanox.com]
> Sent: Wednesday, January 10, 2018 4:52 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; dev@dpdk.org; Olivier MATZ
> <olivier.matz@6wind.com>; Burakov, Anatoly <anatoly.burakov@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v1] app/testpmd: support command echo in
> CLI batch loading
>
>
> > -----Original Message-----
> > From: Lu, Wenzhuo [mailto:wenzhuo.lu@intel.com]
> > Sent: Wednesday, January 10, 2018 4:36 PM
> > To: Xueming(Steven) Li <xuemingl@mellanox.com>
> > Cc: Wu, Jingjing <jingjing.wu@intel.com>; dev@dpdk.org; Olivier MATZ
> > <olivier.matz@6wind.com>; Burakov, Anatoly <anatoly.burakov@intel.com>
> > Subject: RE: [dpdk-dev] [PATCH v1] app/testpmd: support command echo
> > in CLI batch loading
> >
> > Hi Xueming,
> >
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xueming Li
> > > Sent: Tuesday, December 26, 2017 10:26 PM
> > > Cc: Xueming Li <xuemingl@mellanox.com>; Wu, Jingjing
> > > <jingjing.wu@intel.com>; dev@dpdk.org; Olivier MATZ
> > > <olivier.matz@6wind.com>; Burakov, Anatoly
> > > <anatoly.burakov@intel.com>
> > > Subject: [dpdk-dev] [PATCH v1] app/testpmd: support command echo in
> > > CLI batch loading
> > >
> > > Use first bit of verbose_level to enable CLI echo of batch loading.
> > After this patch, the first bit of verbose_level is ambiguous. It can
> > still enable/disable the log print.
> > Is it by design?
> You are correct, there are some code in testpmd simply testing verbose>0.
> How about changing all the test to: verbose & 1? I have another patchset
> using other bits of verbose...
I don't object to give more meaning to verbose. Agree with "verbose & 1". As you said, now only 0 and 1 has meaning.
Don't forget to comment this variable carefully. And also update the doc 'testpmd_funcs.rst' to let the users know how to use the new functions of this CLI 'set verbose (level)'.
next prev parent reply other threads:[~2018-01-10 12:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 15:45 [dpdk-dev] [PATCH 0/3] enable echo when CLI loading from file Xueming Li
2017-11-15 15:45 ` [dpdk-dev] [PATCH 1/3] lib/cmdline: add echo support in batch " Xueming Li
2017-12-11 12:29 ` Burakov, Anatoly
2017-12-19 10:30 ` Olivier MATZ
2017-12-19 11:20 ` Xueming(Steven) Li
2017-12-26 14:25 ` [dpdk-dev] [PATCH v1] app/testpmd: support command echo in CLI batch loading Xueming Li
2018-01-10 8:35 ` Lu, Wenzhuo
2018-01-10 8:51 ` Xueming(Steven) Li
2018-01-10 12:25 ` Lu, Wenzhuo [this message]
2018-01-10 14:14 ` Xueming(Steven) Li
2017-11-15 15:45 ` [dpdk-dev] [PATCH 2/3] " Xueming Li
2017-12-11 12:36 ` Burakov, Anatoly
2017-11-15 15:45 ` [dpdk-dev] [PATCH 3/3] test: update batch loading test Xueming Li
2017-12-11 12:33 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09093B70DC7C@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=olivier.matz@6wind.com \
--cc=xuemingl@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).