From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wenzhuo.lu@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 0D4C31B016
 for <dev@dpdk.org>; Thu, 11 Jan 2018 03:07:45 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga007.jf.intel.com ([10.7.209.58])
 by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 10 Jan 2018 18:07:44 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,342,1511856000"; 
   d="scan'208";a="9482767"
Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204])
 by orsmga007.jf.intel.com with ESMTP; 10 Jan 2018 18:07:44 -0800
Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by
 FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Wed, 10 Jan 2018 18:07:44 -0800
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
 FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Wed, 10 Jan 2018 18:07:44 -0800
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.189]) by
 SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002;
 Thu, 11 Jan 2018 10:07:41 +0800
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>, "Yigit, Ferruh"
 <ferruh.yigit@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Wu, Jingjing" <jingjing.wu@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf PMD
Thread-Index: AQHTidpKlw3Wv+TbfkWg1e/zRuy3qaNs02SAgAEWzbA=
Date: Thu, 11 Jan 2018 02:07:41 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B70E202@shsmsx102.ccr.corp.intel.com>
References: <1515388414-16214-1-git-send-email-wenzhuo.lu@intel.com>
 <1515564961-79227-1-git-send-email-wenzhuo.lu@intel.com>
 <1515564961-79227-3-git-send-email-wenzhuo.lu@intel.com>
 <20180110091525.7f6abb3b@xeon-e3>
In-Reply-To: <20180110091525.7f6abb3b@xeon-e3>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf PMD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Jan 2018 02:07:47 -0000

Hi Stephen,

> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Thursday, January 11, 2018 1:15 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Wu, Jingjing <jingjing.wu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf P=
MD
>=20
> On Wed, 10 Jan 2018 14:15:49 +0800
> Wenzhuo Lu <wenzhuo.lu@intel.com> wrote:
>=20
> > +
> > +#define AVF_MAX_NUM_QUEUES       16
> > +/* Vlan table size */
> > +#define AVF_VLAN_TB_SIZE               (4096 / (CHAR_BIT * sizeof(uint=
32_t)))
>=20
> You could use ETHER_MAX_VLAN_ID (which is 4095).
> Also it is most efficient if bit tables use unsigned long to access.
Thanks for the suggestion.
I found this macro is useless. I'd like just removing it.

Hi Ferruh,
As this patch set is accepted to next-net, I can sent a fixes patch for thi=
s change. Is it OK? Would you like helping merge the fixes to the original =
patch? Thanks.