From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 6A3122C57 for ; Thu, 11 Jan 2018 05:52:26 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2018 20:52:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,343,1511856000"; d="scan'208";a="9856177" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga008.jf.intel.com with ESMTP; 10 Jan 2018 20:52:25 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 10 Jan 2018 20:52:24 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 10 Jan 2018 20:52:23 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.189]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Thu, 11 Jan 2018 12:52:22 +0800 From: "Lu, Wenzhuo" To: Stephen Hemminger , "Yigit, Ferruh" CC: "dev@dpdk.org" , "Wu, Jingjing" Thread-Topic: [dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf PMD Thread-Index: AQHTidpKlw3Wv+TbfkWg1e/zRuy3qaNs0/yAgAFHlhA= Date: Thu, 11 Jan 2018 04:52:21 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B70E2C4@shsmsx102.ccr.corp.intel.com> References: <1515388414-16214-1-git-send-email-wenzhuo.lu@intel.com> <1515564961-79227-1-git-send-email-wenzhuo.lu@intel.com> <1515564961-79227-3-git-send-email-wenzhuo.lu@intel.com> <20180110091733.229a39ad@xeon-e3> In-Reply-To: <20180110091733.229a39ad@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jan 2018 04:52:27 -0000 Hi Stephen, > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Thursday, January 11, 2018 1:18 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Wu, Jingjing > Subject: Re: [dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf P= MD >=20 > On Wed, 10 Jan 2018 14:15:49 +0800 > Wenzhuo Lu wrote: >=20 > > +/* spinlock func for base code */ > > +void > > +avf_init_spinlock_d(struct avf_spinlock *sp) { > > + rte_spinlock_init(&sp->spinlock); > > +} > > + > > +void > > +avf_acquire_spinlock_d(struct avf_spinlock *sp) { > > + rte_spinlock_lock(&sp->spinlock); > > +} > > + > > +void > > +avf_release_spinlock_d(struct avf_spinlock *sp) { > > + rte_spinlock_unlock(&sp->spinlock); > > +} > > + > > +void > > +avf_destroy_spinlock_d(__rte_unused struct avf_spinlock *sp) { } >=20 > You might want to inline these (in a header file) if in critical path. Thanks for the comments. Will send a patch for it. Hi Ferruh, The same question. I'll send a patch base on next-net to change it. If it's= not OK and I need to rework the whole patch set, please let me know. Thank= s.