From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 5803F7CD8 for ; Thu, 25 Jan 2018 03:58:19 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2018 18:58:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,409,1511856000"; d="scan'208";a="22380668" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 24 Jan 2018 18:58:18 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 24 Jan 2018 18:58:18 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 24 Jan 2018 18:58:18 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.189]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Thu, 25 Jan 2018 10:58:16 +0800 From: "Lu, Wenzhuo" To: "Hu, Jiayu" , "dev@dpdk.org" CC: "shahafs@mellanox.com" , "Yao, Lei A" Thread-Topic: [PATCH] app/testpmd: fix failing to enable SW checksum calculation Thread-Index: AQHTlYGcJN3v/67jBEKPnWo4r60KaaOD5SAQ Date: Thu, 25 Jan 2018 02:58:15 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B715E6B@shsmsx102.ccr.corp.intel.com> References: <1516846424-19929-1-git-send-email-jiayu.hu@intel.com> In-Reply-To: <1516846424-19929-1-git-send-email-jiayu.hu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix failing to enable SW checksum calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 02:58:20 -0000 Hi Jiayu, > -----Original Message----- > From: Hu, Jiayu > Sent: Thursday, January 25, 2018 10:14 AM > To: dev@dpdk.org > Cc: shahafs@mellanox.com; Lu, Wenzhuo ; Yao, Lei > A ; Hu, Jiayu > Subject: [PATCH] app/testpmd: fix failing to enable SW checksum calculati= on >=20 > In current design, we can't enable SW checksum calculation for the device= s > which don't have checksum offloading abilities via the command "csum set > ip|tcp|udp|sctp|outer-ip sw ". Confused, you mean it's an issue or the expected behavior? > But SW checksum calculation shouldn't depend on HW offloading abilities. > This patch is to fix this issue. >=20 > Fixes: 3926dd2b6668 ("app/testpmd: enforce offload capabilities check") > Signed-off-by: Jiayu Hu > --- > app/test-pmd/cmdline.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) >=20 > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > 9f12c0f..a2db9b7 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -3706,40 +3706,40 @@ cmd_csum_parsed(void *parsed_result, > hw =3D 1; >=20 > if (!strcmp(res->proto, "ip")) { > - if (dev_info.tx_offload_capa & > - > DEV_TX_OFFLOAD_IPV4_CKSUM) { > + if (hw =3D=3D 0 || (dev_info.tx_offload_capa & You mean SW can support the capability anyway, not need to check anything, = right?