From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id BFC081B355 for ; Fri, 26 Jan 2018 08:32:00 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jan 2018 23:31:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,415,1511856000"; d="scan'208";a="24892984" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 25 Jan 2018 23:31:59 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 25 Jan 2018 23:31:59 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.130]) with mapi id 14.03.0319.002; Fri, 26 Jan 2018 15:31:58 +0800 From: "Lu, Wenzhuo" To: Stephen Hemminger , Thomas Monjalon CC: Moti Haimovsky , "dev@dpdk.org" , "shahafs@mellanox.com" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by default Thread-Index: AQHTlCHmHkwI5lrCGEy2y6PyHLPjFqODyh5w///+b4CAAHSmgIABib1w Date: Fri, 26 Jan 2018 07:31:57 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B721CB9@shsmsx102.ccr.corp.intel.com> References: <1516695081-178919-1-git-send-email-motih@mellanox.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B715D7A@shsmsx102.ccr.corp.intel.com> <60691740.PPs9Gye6m2@xps> <20180125080141.0dd6ac91@xeon-e3> In-Reply-To: <20180125080141.0dd6ac91@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 07:32:01 -0000 Hi Stephen, > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Friday, January 26, 2018 12:02 AM > To: Thomas Monjalon > Cc: Lu, Wenzhuo ; Moti Haimovsky > ; dev@dpdk.org; shahafs@mellanox.com; Yigit, > Ferruh > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by > default >=20 > On Thu, 25 Jan 2018 10:04:11 +0100 > Thomas Monjalon wrote: >=20 > > 25/01/2018 02:11, Lu, Wenzhuo: > > > > --- a/app/test-pmd/testpmd.c > > > > +++ b/app/test-pmd/testpmd.c > > > > @@ -305,9 +305,7 @@ struct fwd_engine * fwd_engines[] =3D { > > > > */ > > > > struct rte_eth_rxmode rx_mode =3D { > > > > .max_rx_pkt_len =3D ETHER_MAX_LEN, /**< Default maximum frame > > > > length. */ > > > > - .offloads =3D (DEV_RX_OFFLOAD_VLAN_FILTER | > > > > - DEV_RX_OFFLOAD_VLAN_STRIP | > > > > - DEV_RX_OFFLOAD_CRC_STRIP), > > > > + .offloads =3D 0, > > > > > > Change the default behavior may trigger other problems. I think TX > offload could be a good reference. Get the capability and check what's > supported first, then ignore the not supported functions with printing a > warning but not block anything... > > > > I agree that we should check the capabilities before requesting an offl= oad. > > But I disagree on another point: we should not enable an offload if > > the user did not request it explicitly. It makes things unclear. > > This is a testing tool, it should be close to the ethdev API behavior. > > > > Why these offload flags are silently enabled? >=20 > Also all virtual devices ignore CRC strip. Look like it's the case the device ignores the flag if it doesn't have the = capability.