From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <wenzhuo.lu@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
by dpdk.org (Postfix) with ESMTP id 0EA291B647
for <dev@dpdk.org>; Wed, 31 Jan 2018 04:16:49 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga002.jf.intel.com ([10.7.209.21])
by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
30 Jan 2018 19:16:47 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,437,1511856000"; d="scan'208";a="30793348"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
by orsmga002.jf.intel.com with ESMTP; 30 Jan 2018 19:16:47 -0800
Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by
fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
id 14.3.319.2; Tue, 30 Jan 2018 19:16:47 -0800
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS)
id 14.3.319.2; Tue, 30 Jan 2018 19:16:47 -0800
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by
SHSMSX101.ccr.corp.intel.com ([169.254.1.192]) with mapi id 14.03.0319.002;
Wed, 31 Jan 2018 11:16:45 +0800
From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: Moti Haimovsky <motih@mellanox.com>, "thomas@monjalon.net"
<thomas@monjalon.net>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH v4] app/testpmd: do not enable Rx offloads by default
Thread-Index: AQHTmajiYN9LrOycRkqd1RLs8dJ3D6ONT2DA
Date: Wed, 31 Jan 2018 03:16:44 +0000
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B7245B5@shsmsx102.ccr.corp.intel.com>
References: <1517301847-169326-1-git-send-email-motih@mellanox.com>
<1517302832-170105-1-git-send-email-motih@mellanox.com>
In-Reply-To: <1517302832-170105-1-git-send-email-motih@mellanox.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: do not enable Rx offloads by
default
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Jan 2018 03:16:51 -0000
Hi Moti,
> -----Original Message-----
> From: Moti Haimovsky [mailto:motih@mellanox.com]
> Sent: Tuesday, January 30, 2018 5:01 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; thomas@monjalon.net
> Cc: dev@dpdk.org; Moti Haimovsky <motih@mellanox.com>
> Subject: [PATCH v4] app/testpmd: do not enable Rx offloads by default
>=20
> Removed the hardcoded preconfigured Rx offload configuration from
> testpmd and changed the Rx offload command line parameters from disable
> to enable.
> Testers who wish to use these offloads will now have to explicitly write =
them
> in the command-line when running testpmd.
>=20
> Motivation:
> Some PMDs such at the mlx4 may not implement all the offloads.
> After the offload API rework assuming no offload is enabled by default,
> commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
> commit cba7f53b717d ("ethdev: introduce Tx queue offloads API")=20
As TX mentioned here and I see TX offload also have a default configuration=
. Is it better to handle TX too in one patch? It may help to track the moti=
vation later.