From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id CF0F81E298; Tue, 12 Jun 2018 04:25:57 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jun 2018 19:25:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,212,1526367600"; d="scan'208";a="207265366" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga004.jf.intel.com with ESMTP; 11 Jun 2018 19:25:56 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 11 Jun 2018 19:25:56 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.223]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0319.002; Tue, 12 Jun 2018 10:25:54 +0800 From: "Lu, Wenzhuo" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH] net/ixgbe: add support for VLAN in IP mode FDIR Thread-Index: AQHT/LAziDb1e/gEK0WzJ+uBs+3sg6Rb7jhQ Date: Tue, 12 Jun 2018 02:25:54 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B7E83F7@shsmsx102.ccr.corp.intel.com> References: <1528189935-34943-1-git-send-email-wei.zhao1@intel.com> <1528189935-34943-3-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1528189935-34943-3-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: add support for VLAN in IP mode FDIR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jun 2018 02:25:58 -0000 Hi Wei, > -----Original Message----- > From: Zhao1, Wei > Sent: Tuesday, June 5, 2018 5:12 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; stable@dpdk.org; Zhao1, Wei > > Subject: [PATCH] net/ixgbe: add support for VLAN in IP mode FDIR >=20 > In IP mode FDIR, X550 can support not only 4 tuple parameters but also vl= an > tci in protocol, so add this feature to flow parser. >=20 > Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") >=20 > Signed-off-by: Wei Zhao > --- > drivers/net/ixgbe/ixgbe_flow.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flo= w.c > index 0427e6f..f5e7805 100644 > --- a/drivers/net/ixgbe/ixgbe_flow.c > +++ b/drivers/net/ixgbe/ixgbe_flow.c > @@ -322,7 +322,8 @@ cons_parse_ntuple_filter(const struct rte_flow_attr > *attr, > } > /* check if the next not void item is IPv4 */ The comment should be updated too, if we need below change. > item =3D next_no_void_pattern(pattern, item); > - if (item->type !=3D RTE_FLOW_ITEM_TYPE_IPV4) { > + if (item->type !=3D RTE_FLOW_ITEM_TYPE_IPV4 && > + item->type !=3D RTE_FLOW_ITEM_TYPE_VLAN) { > rte_flow_error_set(error, > EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, > item, "Not supported by ntuple filter");=20 Really confused. I see the above code is already wrapped by " if (item->typ= e =3D=3D RTE_FLOW_ITEM_TYPE_VLAN) {". You want to support double vlan?