From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 9F8E61B706 for ; Fri, 14 Dec 2018 09:10:04 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Dec 2018 00:10:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,352,1539673200"; d="scan'208";a="118507580" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 14 Dec 2018 00:10:03 -0800 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 14 Dec 2018 00:10:03 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 14 Dec 2018 00:10:02 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.182]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.203]) with mapi id 14.03.0415.000; Fri, 14 Dec 2018 16:10:00 +0800 From: "Lu, Wenzhuo" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "Yang, Qiming" , "Li, Xiaoyun" , "Wu, Jingjing" Thread-Topic: [dpdk-dev] [PATCH v3 20/34] net/ice: support link update Thread-Index: AQHUkefAhszcWhLWu0Gf0jIOvqN6iaV71v4AgAGOyqD//53ggIAA4T2w Date: Fri, 14 Dec 2018 08:09:59 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093FE14183@shsmsx102.ccr.corp.intel.com> References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com> <1544598004-27099-1-git-send-email-wenzhuo.lu@intel.com> <1544598004-27099-21-git-send-email-wenzhuo.lu@intel.com> <039ED4275CED7440929022BC67E70611532FE4DA@SHSMSX103.ccr.corp.intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093FE13DF0@shsmsx102.ccr.corp.intel.com> <039ED4275CED7440929022BC67E70611532FEB6D@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E70611532FEB6D@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 20/34] net/ice: support link update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 08:10:05 -0000 > -----Original Message----- > From: Zhang, Qi Z > Sent: Friday, December 14, 2018 10:43 AM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Yang, Qiming ; Li, Xiaoyun > ; Wu, Jingjing > Subject: RE: [dpdk-dev] [PATCH v3 20/34] net/ice: support link update >=20 >=20 >=20 > > -----Original Message----- > > From: Lu, Wenzhuo > > Sent: Friday, December 14, 2018 8:36 AM > > To: Zhang, Qi Z ; dev@dpdk.org > > Cc: Yang, Qiming ; Li, Xiaoyun > > ; Wu, Jingjing > > Subject: RE: [dpdk-dev] [PATCH v3 20/34] net/ice: support link update > > > > Hi Qi, > > > > > -----Original Message----- > > > From: Zhang, Qi Z > > > Sent: Thursday, December 13, 2018 4:47 PM > > > To: Lu, Wenzhuo ; dev@dpdk.org > > > Cc: Lu, Wenzhuo ; Yang, Qiming > > > ; Li, Xiaoyun ; Wu, > > > Jingjing > > > Subject: RE: [dpdk-dev] [PATCH v3 20/34] net/ice: support link > > > update > > > > > > Hi Wenzhuo: > > > > > > > -----Original Message----- > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > > > > Sent: Wednesday, December 12, 2018 3:00 PM > > > > To: dev@dpdk.org > > > > Cc: Lu, Wenzhuo ; Yang, Qiming > > > > ; Li, Xiaoyun ; Wu, > > > > Jingjing > > > > Subject: [dpdk-dev] [PATCH v3 20/34] net/ice: support link update > > > > > > > > Add ops link_update. > > > > > > > > > > +ice_interrupt_handler(void *param) { > > > > + struct rte_eth_dev *dev =3D (struct rte_eth_dev *)param; > > > > + struct ice_hw *hw =3D ICE_DEV_PRIVATE_TO_HW(dev->data- > > > >dev_private); > > > > + uint32_t oicr; > > > > > > I saw the patch also enabled interrupt handler, which looks like be > > > independent and not related with the commit log. > > > It's better to separate it. > > Here we only enable LSC interrupt for link update. So, I prefer > > putting it in this patch. >=20 > OK, I will suggest to modify the commit log to include the LSC part, sinc= e > enable LSC is different with add ops link_update. Will add it in the log.