From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 2252844C3; Fri, 12 Apr 2019 03:44:04 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Apr 2019 18:44:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,339,1549958400"; d="scan'208";a="290847455" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 11 Apr 2019 18:44:03 -0700 Received: from fmsmsx161.amr.corp.intel.com (10.18.125.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 11 Apr 2019 18:44:03 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX161.amr.corp.intel.com (10.18.125.9) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 11 Apr 2019 18:44:03 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.164]) with mapi id 14.03.0415.000; Fri, 12 Apr 2019 09:44:01 +0800 From: "Lu, Wenzhuo" To: "Zhang, Qi Z" , "Xing, Beilei" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/i40e: fix scattered Rx enabling Thread-Index: AQHU77F/BYgAxGBXmkm8iLYuwI1kUqY3wq9Q Date: Fri, 12 Apr 2019 01:44:00 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909407FC7FB@shsmsx102.ccr.corp.intel.com> References: <20190410152623.27995-1-qi.z.zhang@intel.com> In-Reply-To: <20190410152623.27995-1-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix scattered Rx enabling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2019 01:44:05 -0000 Hi Qi, > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, April 10, 2019 11:26 PM > To: Xing, Beilei ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Zhang, Qi Z ; stable@dpdk.org > Subject: [PATCH v2] net/i40e: fix scattered Rx enabling >=20 > No need to add additional vlan tag size for max packet size, since for i4= 0e, > the queue's Rx Max Frame Size (rxq->max_pkt_len) already includes the vla= n > header size. >=20 > Fixes: a3c83a2527e1 ("net/i40e: enable runtime queue setup") > Fixes: 4861cde46116 ("i40e: new poll mode driver") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qi Zhang Looks good to me. Except it seems that the fixes don't include the VF chang= e. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 34B53A0096 for ; Fri, 12 Apr 2019 03:44:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 04A574CC3; Fri, 12 Apr 2019 03:44:07 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 2252844C3; Fri, 12 Apr 2019 03:44:04 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Apr 2019 18:44:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,339,1549958400"; d="scan'208";a="290847455" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 11 Apr 2019 18:44:03 -0700 Received: from fmsmsx161.amr.corp.intel.com (10.18.125.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 11 Apr 2019 18:44:03 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX161.amr.corp.intel.com (10.18.125.9) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 11 Apr 2019 18:44:03 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.164]) with mapi id 14.03.0415.000; Fri, 12 Apr 2019 09:44:01 +0800 From: "Lu, Wenzhuo" To: "Zhang, Qi Z" , "Xing, Beilei" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/i40e: fix scattered Rx enabling Thread-Index: AQHU77F/BYgAxGBXmkm8iLYuwI1kUqY3wq9Q Date: Fri, 12 Apr 2019 01:44:00 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909407FC7FB@shsmsx102.ccr.corp.intel.com> References: <20190410152623.27995-1-qi.z.zhang@intel.com> In-Reply-To: <20190410152623.27995-1-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix scattered Rx enabling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190412014400.JohlpTlwBOawdXnRBhLSzcA8XHsXgAHMcKu7uKSyBAA@z> Hi Qi, > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, April 10, 2019 11:26 PM > To: Xing, Beilei ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Zhang, Qi Z ; stable@dpdk.org > Subject: [PATCH v2] net/i40e: fix scattered Rx enabling >=20 > No need to add additional vlan tag size for max packet size, since for i4= 0e, > the queue's Rx Max Frame Size (rxq->max_pkt_len) already includes the vla= n > header size. >=20 > Fixes: a3c83a2527e1 ("net/i40e: enable runtime queue setup") > Fixes: 4861cde46116 ("i40e: new poll mode driver") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qi Zhang Looks good to me. Except it seems that the fixes don't include the VF chang= e.