From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82504A04B4; Tue, 19 Nov 2019 07:43:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 33E4A1C0B; Tue, 19 Nov 2019 07:43:07 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 6D7942AB; Tue, 19 Nov 2019 07:43:05 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Nov 2019 22:43:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,322,1569308400"; d="scan'208";a="204304316" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga008.fm.intel.com with ESMTP; 18 Nov 2019 22:43:04 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 18 Nov 2019 22:43:03 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 18 Nov 2019 22:43:03 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.108]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.213]) with mapi id 14.03.0439.000; Tue, 19 Nov 2019 14:43:01 +0800 From: "Lu, Wenzhuo" To: "Cui, LunyuanX" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v3] net/e1000: fix link status update Thread-Index: AQHVnd4CU1VPIOsK6UudA93aMxyPgKeSCpQg Date: Tue, 19 Nov 2019 06:43:01 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909408A15C5@shsmsx102.ccr.corp.intel.com> References: <20191115144823.3647-1-lunyuanx.cui@intel.com> <20191118145801.78186-1-lunyuanx.cui@intel.com> In-Reply-To: <20191118145801.78186-1-lunyuanx.cui@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/e1000: fix link status update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Lunyuan, > -----Original Message----- > From: Cui, LunyuanX > Sent: Monday, November 18, 2019 10:58 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Cui, LunyuanX > ; stable@dpdk.org > Subject: [PATCH v3] net/e1000: fix link status update >=20 > Unassigned variable should not be used as judgment, and there is no need Don't understand "Unassigned variable should not be used as judgment ". Whi= ch one is this " Unassigned variable"? > to update link status according to old link status. Don't understand why " no need to update link status according to old link = status ". Please add more info about what problem this patch wants to fix. Thanks. > This patch fix the issue. >=20 > Change the variable from link_check to link_up. >=20 > Fixes: 80ba61115e77 ("net/e1000: use link status helper functions") > Cc: stable@dpdk.org >=20 > Signed-off-by: Lunyuan Cui > --- > v3: > * Change the variable from link_check to link_up. >=20 > v2 > * Delete incorrect judgment > --- > drivers/net/e1000/em_ethdev.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) >=20 > diff --git a/drivers/net/e1000/em_ethdev.c > b/drivers/net/e1000/em_ethdev.c index 9a88b50b2..080cbe2df 100644 > --- a/drivers/net/e1000/em_ethdev.c > +++ b/drivers/net/e1000/em_ethdev.c >=20 > /* Now we check if a transition has happened */ Looks like this comment need to be removed if the below check changes. But = still, don't know why we should change the check. > - if (link_check && (link.link_status =3D=3D ETH_LINK_DOWN)) { > + if (link_up) {