From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id B5EECC69E for ; Fri, 31 Jul 2015 03:03:58 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 30 Jul 2015 18:03:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,580,1432623600"; d="scan'208";a="739233452" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by orsmga001.jf.intel.com with ESMTP; 30 Jul 2015 18:03:56 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by PGSMSX107.gar.corp.intel.com (10.221.44.105) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 31 Jul 2015 09:03:55 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.126]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.18]) with mapi id 14.03.0224.002; Fri, 31 Jul 2015 09:03:54 +0800 From: "Lu, Wenzhuo" To: "Mcnamara, John" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] e1000: fix ieee1588 timestamp issue Thread-Index: AQHQyqKXnhR4XyEWO0iB8lsNLVsHH53zQUsAgAGC1/A= Date: Fri, 31 Jul 2015 01:03:53 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909D19DAD@shsmsx102.ccr.corp.intel.com> References: <1438245257-7328-1-git-send-email-wenzhuo.lu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] e1000: fix ieee1588 timestamp issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jul 2015 01:03:59 -0000 Hi John, > -----Original Message----- > From: Mcnamara, John > Sent: Thursday, July 30, 2015 5:59 PM > To: Lu, Wenzhuo; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] e1000: fix ieee1588 timestamp issue >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > > Sent: Thursday, July 30, 2015 9:34 AM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH] e1000: fix ieee1588 timestamp issue > > > > Ieee1588 reads system time to set its timestamp. On 1G NICs, for > > example, i350, system time is disabled by default. It means the > > ieee1588 timestamp will always be 0. > > This patch enables system time when ieee1588 is enabled. >=20 > Looks good. >=20 >=20 > > +#define E1000_TSAUXC_DISABLE_SYSTIME 0x80000000 >=20 > Probably best to move this to the top of the file with the other timesync= defines. Thanks for looking into this. I'll send a V2. >=20 >=20 > I wonder if this would also fix the following known issue with i210 times= yncing > from the release notes: >=20 > http://dpdk.org/doc/guides/rel_notes/known_issues.html#ieee1588-support- > possibly-not-working-with-an-intel-ethernet-controller-i210-nic >=20 > I don't have an i210 NIC to test but perhaps someone could verify it. >=20 > John