From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id CBCED235; Tue, 31 Jul 2018 16:24:46 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2018 07:24:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,427,1526367600"; d="scan'208";a="77071287" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga001.fm.intel.com with ESMTP; 31 Jul 2018 07:24:43 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.208]) by IRSMSX102.ger.corp.intel.com ([169.254.2.110]) with mapi id 14.03.0319.002; Tue, 31 Jul 2018 15:24:42 +0100 From: "Coyle, David" To: "Van Haaren, Harry" , "dev@dpdk.org" CC: "Richardson, Bruce" , "stable@dpdk.org" , "thomas@monjalon.net" , "Xing, Beilei" , "Zhang, Qi Z" Thread-Topic: [PATCH v2] net/i40e: fix avx2 driver check for rx rearm Thread-Index: AQHUKCucvNKMLrRW+ECEMmrorjqwN6SpYhIw Date: Tue, 31 Jul 2018 14:24:41 +0000 Message-ID: <6CC82E0EC574F343969147E75534348B1D908C77@IRSMSX103.ger.corp.intel.com> References: <1532971818-191870-1-git-send-email-harry.van.haaren@intel.com> <1532972059-191978-1-git-send-email-harry.van.haaren@intel.com> In-Reply-To: <1532972059-191978-1-git-send-email-harry.van.haaren@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTQ0NDVhZWYtMmZjMi00NTFhLWE2ZjItMDEyNjM4MTZkZWE5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRERCaHJtakZUbENwaXhDVTJXdTFGeWphUHpDZHdZdSs3cGI4c0gxSXpJNTRzTGNLQUE1N0Ywb0tNZ0lFZytidyJ9 x-ctpclassification: CTP_NT x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix avx2 driver check for rx rearm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jul 2018 14:24:47 -0000 -----Original Message----- From: Van Haaren, Harry = Sent: Monday, July 30, 2018 6:34 PM To: dev@dpdk.org Cc: Van Haaren, Harry ; Richardson, Bruce ; stable@dpdk.org; thomas@monjalon.net; Coyle, David= ; Xing, Beilei ; Zhang, Qi Z= Subject: [PATCH v2] net/i40e: fix avx2 driver check for rx rearm This commit fixes an infinite loop bug that could occur if the i40e AVX2 dr= iver is used, and high traffic rates cause the mempool from which the rxq p= ulls mbufs to become empty. The result would be an infinite loop of checking if we should perform an rx= rearm, calling the function and an error return due the the mempool being = emtpy. The fix is to align the code in the AVX2 driver with the SSE driver, where = an if() is used instead of a while(), allowing the thread to return from i4= 0e rx function even if the mempool is empty. Fixes: dafadd73762e ("net/i40e: add AVX2 Rx function") Cc: bruce.richardson@intel.com Cc: stable@dpdk.org Reported-by: David Coyle Signed-off-by: Harry van Haaren Acked-by: Brendan Ryan Tested-by: David Coyle -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact = the sender and delete all copies.