From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08EDEA00C5; Thu, 7 May 2020 10:08:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D240D1DAB2; Thu, 7 May 2020 10:08:48 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id B4D961DA1A for ; Thu, 7 May 2020 10:08:46 +0200 (CEST) IronPort-SDR: tioeM+wpy4+jD6MOII1taDJfmoD76wBvLRd1vLV9jhGeNWR5CDkf6UQqzyBUbDnN4QNImDjjqV ohmFm0QErRLQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 01:08:45 -0700 IronPort-SDR: WWrnLoKY8uKIru5w7RxYj9KSOw/9Rah1AqhN4zDCQitVagFZ9W4a8saXKFvUyK0h3pS5we0t2e HVcHJaU1SvYg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,363,1583222400"; d="scan'208";a="462056118" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 07 May 2020 01:08:45 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 01:08:45 -0700 Received: from cdsmsx104.ccr.corp.intel.com (172.17.3.38) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 01:08:45 -0700 Received: from cdsmsx102.ccr.corp.intel.com ([169.254.2.168]) by CDSMSX104.ccr.corp.intel.com ([169.254.4.250]) with mapi id 14.03.0439.000; Thu, 7 May 2020 16:08:42 +0800 From: "Zhang, AlvinX" To: "Guo, Jia" , "dev@dpdk.org" CC: "Zhao1, Wei" , "Ye, Xiaolong" Thread-Topic: [PATCH] net/igc: fix memory illegal accesses Thread-Index: AQHWJBPFqOfLxJVjvE2UAO89QuFHBKibo66AgACXhoA= Date: Thu, 7 May 2020 08:08:41 +0000 Message-ID: <6CE17E955B70FA409286764E3E0B36411648135A@CDSMSX102.ccr.corp.intel.com> References: <20200507020133.14412-1-alvinx.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.17.6.105] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/igc: fix memory illegal accesses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" SGkgSmlhLA0KRmlyc3Qgb2YgYWxsLCB0aGlzIGlzIGEgY292ZXJpdHkgaXNzdWUsIGFuZCBpdCdz IHJlYWxseSBhIGZhbHNlIHBvc2l0aXZlcy4gQnV0IGRvIHNvbWUgbWFjcm8gY2hlY2tpbmcgd2ls bCBpbXByb3ZlIGNvZGUgcm9idXN0bmVzcy4NCg0KVGhhbmtzLA0KQWx2aW4NCg0KPiAtLS0tLU9y aWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBHdW8sIEppYQ0KPiBTZW50OiBUaHVyc2RheSwg TWF5IDcsIDIwMjAgMjozMCBQTQ0KPiBUbzogWmhhbmcsIEFsdmluWCA8YWx2aW54LnpoYW5nQGlu dGVsLmNvbT47IGRldkBkcGRrLm9yZw0KPiBDYzogWmhhbzEsIFdlaSA8d2VpLnpoYW8xQGludGVs LmNvbT47IFllLCBYaWFvbG9uZw0KPiA8eGlhb2xvbmcueWVAaW50ZWwuY29tPg0KPiBTdWJqZWN0 OiBSZTogW1BBVENIXSBuZXQvaWdjOiBmaXggbWVtb3J5IGlsbGVnYWwgYWNjZXNzZXMNCj4gDQo+ IGhpLCBhbHZpbg0KPiANCj4gDQo+IE9uIDUvNy8yMDIwIDEwOjAxIEFNLCBhbHZpbnguemhhbmdA aW50ZWwuY29tIHdyb3RlOg0KPiA+IEZyb206IEFsdmluIFpoYW5nIDxhbHZpbnguemhhbmdAaW50 ZWwuY29tPg0KPiA+DQo+ID4gQWRkIG1lbW9yeSBhY2Nlc3Mgb3V0LW9mLWJvdW5kcyBjaGVjay4N Cj4gDQo+IA0KPiBDb3VsZCB5b3UgZXhwbGFpbiB3aHkgYWRkIC4uLj/CoCBJZiBub3QgYWRkLCB3 aGF0IGlzc3VlPw0KPiANCj4gDQo+ID4NCj4gPiBGaXhlczogYmQzZmNmMGQwZmExIChuZXQvaWdj OiBzdXBwb3J0IFJTUykNCj4gPiBDYzogc3RhYmxlQGRwZGsub3JnDQo+ID4NCj4gPiBTaWduZWQt b2ZmLWJ5OiBBbHZpbiBaaGFuZyA8YWx2aW54LnpoYW5nQGludGVsLmNvbT4NCj4gPiAtLS0NCj4g PiAgIGRyaXZlcnMvbmV0L2lnYy9pZ2NfZXRoZGV2LmMgfCAxMiArKysrKysrKysrLS0NCj4gPiAg IDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQ0KPiA+DQo+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L2lnYy9pZ2NfZXRoZGV2LmMNCj4gPiBiL2RyaXZl cnMvbmV0L2lnYy9pZ2NfZXRoZGV2LmMgaW5kZXggMTZkOThjNi4uY2VkOGZmZCAxMDA2NDQNCj4g PiAtLS0gYS9kcml2ZXJzL25ldC9pZ2MvaWdjX2V0aGRldi5jDQo+ID4gKysrIGIvZHJpdmVycy9u ZXQvaWdjL2lnY19ldGhkZXYuYw0KPiA+IEBAIC0yMjY2LDYgKzIyNjYsOCBAQCBzdGF0aWMgaW50 IGV0aF9pZ2Nfdmxhbl90cGlkX3NldChzdHJ1Y3QNCj4gcnRlX2V0aF9kZXYgKmRldiwNCj4gPiAg IAkJcmV0dXJuIC1FSU5WQUw7DQo+ID4gICAJfQ0KPiA+DQo+ID4gKwlSVEVfQlVJTERfQlVHX09O KEVUSF9SU1NfUkVUQV9TSVpFXzEyOCAlDQo+IElHQ19SU1NfUkRUX1JFR19TSVpFKTsNCj4gPiAr DQo+ID4gICAJLyogc2V0IHJlZGlyZWN0aW9uIHRhYmxlICovDQo+ID4gICAJZm9yIChpID0gMDsg aSA8IEVUSF9SU1NfUkVUQV9TSVpFXzEyODsgaSArPSBJR0NfUlNTX1JEVF9SRUdfU0laRSkNCj4g ew0KPiA+ICAgCQl1bmlvbiBpZ2NfcnNzX3JldGFfcmVnIHJldGEsIHJlZzsNCj4gPiBAQCAtMjI3 OCw3ICsyMjgwLDggQEAgc3RhdGljIGludCBldGhfaWdjX3ZsYW5fdHBpZF9zZXQoc3RydWN0DQo+ IHJ0ZV9ldGhfZGV2ICpkZXYsDQo+ID4gICAJCQkJSUdDX1JTU19SRFRfUkVHX1NJWkVfTUFTSyk7 DQo+ID4NCj4gPiAgIAkJLyogaWYgbm8gbmVlZCB0byB1cGRhdGUgdGhlIHJlZ2lzdGVyICovDQo+ ID4gLQkJaWYgKCFtYXNrKQ0KPiA+ICsJCWlmICghbWFzayB8fA0KPiA+ICsJCQlzaGlmdCA+IChS VEVfUkVUQV9HUk9VUF9TSVpFIC0NCj4gSUdDX1JTU19SRFRfUkVHX1NJWkUpKQ0KPiANCj4gDQo+ IGFsaWdubWVudCBzaG91bGQgYmUgbWF0Y2ggYWJvdmUgcGFyZW50aGVzZXMuDQo+IA0KPiANCj4g PiAgIAkJCWNvbnRpbnVlOw0KPiA+DQo+ID4gICAJCS8qIGNoZWNrIG1hc2sgd2hldGhlciBuZWVk IHRvIHJlYWQgdGhlIHJlZ2lzdGVyIHZhbHVlIGZpcnN0DQo+ICovIEBADQo+ID4gLTIyODksNiAr MjI5Miw3IEBAIHN0YXRpYyBpbnQgZXRoX2lnY192bGFuX3RwaWRfc2V0KHN0cnVjdCBydGVfZXRo X2Rldg0KPiAqZGV2LA0KPiA+ICAgCQkJCQlJR0NfUkVUQShpIC8NCj4gSUdDX1JTU19SRFRfUkVH X1NJWkUpKTsNCj4gPg0KPiA+ICAgCQkvKiB1cGRhdGUgdGhlIHJlZ2lzdGVyICovDQo+ID4gKwkJ UlRFX0JVSUxEX0JVR19PTihzaXplb2YocmV0YS5ieXRlcykgIT0NCj4gSUdDX1JTU19SRFRfUkVH X1NJWkUpOw0KPiA+ICAgCQlmb3IgKGogPSAwOyBqIDwgSUdDX1JTU19SRFRfUkVHX1NJWkU7IGor Kykgew0KPiA+ICAgCQkJaWYgKG1hc2sgJiAoMXUgPDwgaikpDQo+ID4gICAJCQkJcmV0YS5ieXRl c1tqXSA9DQo+ID4gQEAgLTIzMTgsNiArMjMyMiw4IEBAIHN0YXRpYyBpbnQgZXRoX2lnY192bGFu X3RwaWRfc2V0KHN0cnVjdA0KPiBydGVfZXRoX2RldiAqZGV2LA0KPiA+ICAgCQlyZXR1cm4gLUVJ TlZBTDsNCj4gPiAgIAl9DQo+ID4NCj4gPiArCVJURV9CVUlMRF9CVUdfT04oRVRIX1JTU19SRVRB X1NJWkVfMTI4ICUNCj4gSUdDX1JTU19SRFRfUkVHX1NJWkUpOw0KPiA+ICsNCj4gPiAgIAkvKiBy ZWFkIHJlZGlyZWN0aW9uIHRhYmxlICovDQo+ID4gICAJZm9yIChpID0gMDsgaSA8IEVUSF9SU1Nf UkVUQV9TSVpFXzEyODsgaSArPSBJR0NfUlNTX1JEVF9SRUdfU0laRSkNCj4gew0KPiA+ICAgCQl1 bmlvbiBpZ2NfcnNzX3JldGFfcmVnIHJldGE7DQo+ID4gQEAgLTIzMzAsMTIgKzIzMzYsMTQgQEAg c3RhdGljIGludCBldGhfaWdjX3ZsYW5fdHBpZF9zZXQoc3RydWN0DQo+IHJ0ZV9ldGhfZGV2ICpk ZXYsDQo+ID4gICAJCQkJSUdDX1JTU19SRFRfUkVHX1NJWkVfTUFTSyk7DQo+ID4NCj4gPiAgIAkJ LyogaWYgbm8gbmVlZCB0byByZWFkIHJlZ2lzdGVyICovDQo+ID4gLQkJaWYgKCFtYXNrKQ0KPiA+ ICsJCWlmICghbWFzayB8fA0KPiA+ICsJCQlzaGlmdCA+IChSVEVfUkVUQV9HUk9VUF9TSVpFIC0N Cj4gSUdDX1JTU19SRFRfUkVHX1NJWkUpKQ0KPiANCj4gDQo+IHRoZSBzYW1lIGFzIGFib3ZlLg0K PiANCj4gDQo+ID4gICAJCQljb250aW51ZTsNCj4gPg0KPiA+ICAgCQkvKiByZWFkIHJlZ2lzdGVy IGFuZCBnZXQgdGhlIHF1ZXVlIGluZGV4ICovDQo+ID4gICAJCXJldGEuZHdvcmQgPSBJR0NfUkVB RF9SRUdfTEVfVkFMVUUoaHcsDQo+ID4gICAJCQkJSUdDX1JFVEEoaSAvIElHQ19SU1NfUkRUX1JF R19TSVpFKSk7DQo+ID4gKwkJUlRFX0JVSUxEX0JVR19PTihzaXplb2YocmV0YS5ieXRlcykgIT0N Cj4gSUdDX1JTU19SRFRfUkVHX1NJWkUpOw0KPiANCj4gDQo+IG5lZWQgbnVsbCBsaW5lIG9yIG5v IG5lZWQsIHBsZWFzZSBjaGVjayBpdCBhdCB0aGUgcGxhY2UgYW5kIGJlZm9yZS4NCj4gDQo+IA0K PiA+ICAgCQlmb3IgKGogPSAwOyBqIDwgSUdDX1JTU19SRFRfUkVHX1NJWkU7IGorKykgew0KPiA+ ICAgCQkJaWYgKG1hc2sgJiAoMXUgPDwgaikpDQo+ID4gICAJCQkJcmV0YV9jb25mW2lkeF0ucmV0 YVtzaGlmdCArIGpdID0gcmV0YS5ieXRlc1tqXTsNCg==