From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 12FD71B12C for ; Tue, 25 Sep 2018 15:21:00 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2018 06:20:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,302,1534834800"; d="scan'208";a="260089044" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga005.jf.intel.com with ESMTP; 25 Sep 2018 06:20:55 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.213]) by IRSMSX102.ger.corp.intel.com ([169.254.2.180]) with mapi id 14.03.0319.002; Tue, 25 Sep 2018 14:20:54 +0100 From: "Kovacevic, Marko" To: "Ma, Liang J" , "Hunt, David" CC: "dev@dpdk.org" , "Yao, Lei A" , "ktraynor@redhat.com" , "Geary, John" , "Ma, Liang J" Thread-Topic: [dpdk-dev] [PATCH v8 4/4] doc/guides/sample_app_ug/l3_forward_power_man.rst: empty poll update Thread-Index: AQHUTorIvAJzwnQI9kqNDpdAaa3rPKUA+8rg Date: Tue, 25 Sep 2018 13:20:54 +0000 Message-ID: <6DC05C7C5F25994B81B3F2F214251F6602030CB1@IRSMSX104.ger.corp.intel.com> References: <1536070228-6545-1-git-send-email-liang.j.ma@intel.com> <1537191016-26330-1-git-send-email-liang.j.ma@intel.com> <1537191016-26330-4-git-send-email-liang.j.ma@intel.com> In-Reply-To: <1537191016-26330-4-git-send-email-liang.j.ma@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDUzYjA1MTAtZWUxNy00ZTVmLTk1NzUtYzMyMWE0OWMxMjdhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkxlcURwdXpFT2p3VTI4NnZcL1dhQk9UQWxDcFUycFkya0g0bzdsb29la0hzPSJ9 x-ctpclassification: CTP_NT x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v8 4/4] doc/guides/sample_app_ug/l3_forward_power_man.rst: empty poll update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 13:21:01 -0000 > Add empty poll mode command line example >=20 > Signed-off-by: Liang Ma > --- > doc/guides/sample_app_ug/l3_forward_power_man.rst | 29 > +++++++++++++++++++++++ > 1 file changed, 29 insertions(+) >=20 > +Empty Poll Mode > +------------------------- > +There is a new Mode which is added recently. Empty poll mode can be > +enabled by command option --empty-poll. > + > +See "Power Management" chapter in the DPDK Programmer's Guide for > empty poll mode details. Can you embed the link to the Power Management chapter :doc:`Power Management<../prog_guide/power_man>` > +.. code-block:: console > + > + ./l3fwd-power -l xxx -n 4 -w 0000:xx:00.0 -w 0000:xx:00.1 -- -p = 0x3 -P -- > config=3D"(0,0,xx),(1,0,xx)" --empty-poll=3D"0,0,0" -l 14 -m 9 -h 1 > + > +Where, > + > +--empty-poll: Enable the empty poll mode instead of original algorithm > + > +--empty-poll=3D"training_flag, med_threshold, high_threshold" > + > +* training_flag : optional, enable/disable training mode. Default value = is 0. > + > +* med_threshold : optional, indicate the empty poll threshold of modest > state which is customized by user. Default value is 0. > + > +* high_threshold : optional, indicate the empty poll threshold of busy s= tate > which is customized by user. Default value is 0. > + > +* -l : optional, set up the LOW power state frequency index > + > +* -m : optional, set up the MED power state frequency index > + > +* -h : optional, set up the HIGH power state frequency index I think in this over all section needs a lot more explanation like what are= valid training flags and how to get thresholds ect. Also you could highlight the commands it looks better: ``training_flag= `` Thanks, Marko K