From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id F1AFA5F14 for ; Thu, 18 Oct 2018 14:24:47 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Oct 2018 05:24:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,396,1534834800"; d="scan'208";a="272373530" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga005.fm.intel.com with ESMTP; 18 Oct 2018 05:24:46 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.213]) by IRSMSX151.ger.corp.intel.com ([169.254.4.71]) with mapi id 14.03.0319.002; Thu, 18 Oct 2018 13:24:38 +0100 From: "Kovacevic, Marko" To: "Pattan, Reshma" , "dev@dpdk.org" , "Mcnamara, John" CC: "Singh, Jasvinder" Thread-Topic: [PATCH] doc: update softnic doc for flow and qos API support Thread-Index: AQHUZs+HqnM48J+AFki+/W+oQ5RigqUk7AzA Date: Thu, 18 Oct 2018 12:24:37 +0000 Message-ID: <6DC05C7C5F25994B81B3F2F214251F66020382D1@IRSMSX104.ger.corp.intel.com> References: <1539859449-8248-1-git-send-email-reshma.pattan@intel.com> In-Reply-To: <1539859449-8248-1-git-send-email-reshma.pattan@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTkxM2U5YTktMThkMC00OTgyLTkxY2QtMzk1ZTlkY2I2M2E5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieTBOWnk3MjlhcEswQUw0Ym94SXFHU1JWZ2ZVSkJCaVdCK0dLTnhweU1PMnFFemtPamJiOUNEZ1RcL1lZa0lDdkQifQ== x-ctpclassification: CTP_NT x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: update softnic doc for flow and qos API support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2018 12:24:48 -0000 > Update document with flow and qos api support in softnic PMD. >=20 > Signed-off-by: Jasvinder Singh > Signed-off-by: Reshma Pattan > --- > doc/guides/nics/softnic.rst | 119 > ++++++++++++++++++++++++++++++++++++ > 1 file changed, 119 insertions(+) id 1) > + > +QoS API Support: > +---------------- > + > +SoftNIC PMD implements ethdev traffic management APIs ``rte_tm.h`` that > +allow building and committing traffic manager hierarchy, configuring > +hierarchy nodes of the Quality of Service (QoS) scheduler supported by > +DPDK librte_sched library. Furthermore, APIs for run-time update to the > +traffic manager hierarchy are supported by PMD. > + > +SoftNIC PMD also implements ethdev traffic metering and policing APIs > +``rte_mtr.h`` that enables metering and marking of the packets with the > +appropriate color (green, yellow or red), according to the traffic > +metering algorithm. For the meter output color, policer actions can be > +configured which include keep the same packet color (essentially a > +no-op action), override the color the packet or drop the packet. The one thing here I notice is the sentence=20 " policer actions can be configured which include keep the same packet colo= r " "which include keep" sounds weird,=20 Maybe one of these " policer actions can be configured which include the same packet color " " policer actions can be configured which keep the same packet color " > +.. Note: > + > +The SoftNIC does not support the meter object shared by several flows, > +thus only supports creating meter object private to the flow. Once > +meter object is successfully created, it can be linked to the specific > +flow by specifying the ``meter`` flow action in the flow rule. Your note doesn't come out as a note because you didn't indent your text. Note: > + > +The flow must have one terminating actions i.e. ``JMP or RSS or QUEUE or > DROP``. > +For the count and drop actions the underlying PMD doesn't support the > +functionality yet. So it is not recommended for use. Same here. Reviewed-by: Marko Kovacevic