From: "Kovacevic, Marko" <marko.kovacevic@intel.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Yang, Zhiyong" <zhiyong.yang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/pdump: fix port id storage size
Date: Wed, 14 Nov 2018 08:39:11 +0000 [thread overview]
Message-ID: <6DC05C7C5F25994B81B3F2F214251F660205020E@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A3D304B@irsmsx110.ger.corp.intel.com>
> > port_id size should be uint16_t,
> > fix where it is defined as uint8_t
> >
> > Fixes: f8244c6399d9 ("ethdev: increase port id range")
> > Cc: zhiyong.yang@intel.com
> >
> > Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
> > ---
> > app/pdump/main.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/app/pdump/main.c b/app/pdump/main.c index
> > d96556e..baabd04
> > 100644
> > --- a/app/pdump/main.c
> > +++ b/app/pdump/main.c
> > @@ -266,7 +266,7 @@ parse_pdump(const char *optarg)
> > &parse_uint_value, &v);
> > if (ret < 0)
>
> Can you also int type to unit16_t for below two.
>
> int rx_vdev_id;
> int tx_vdev_id;
>
> Thanks,
> Reshma
Sure Reshma will do it right now.
Marko K.
next prev parent reply other threads:[~2018-11-14 8:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 14:26 Marko Kovacevic
2018-11-13 14:30 ` Marko Kovacevic
2018-11-13 14:33 ` [dpdk-dev] [PATCH v2] " Marko Kovacevic
2018-11-14 8:56 ` [dpdk-dev] [PATCH v3] " Marko Kovacevic
2018-11-14 10:28 ` Pattan, Reshma
2018-11-18 20:42 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-11-13 17:09 ` [dpdk-dev] [PATCH] " Pattan, Reshma
2018-11-14 8:39 ` Kovacevic, Marko [this message]
2018-11-14 10:00 ` Pattan, Reshma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6DC05C7C5F25994B81B3F2F214251F660205020E@IRSMSX104.ger.corp.intel.com \
--to=marko.kovacevic@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=reshma.pattan@intel.com \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).