From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <marko.kovacevic@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 25E8E34F3
 for <dev@dpdk.org>; Wed, 14 Nov 2018 09:39:14 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
 by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 14 Nov 2018 00:39:14 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.56,231,1539673200"; d="scan'208";a="85707931"
Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59])
 by fmsmga007.fm.intel.com with ESMTP; 14 Nov 2018 00:39:13 -0800
Received: from irsmsx104.ger.corp.intel.com ([169.254.5.131]) by
 IRSMSX151.ger.corp.intel.com ([169.254.4.122]) with mapi id 14.03.0415.000;
 Wed, 14 Nov 2018 08:39:12 +0000
From: "Kovacevic, Marko" <marko.kovacevic@intel.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Yang, Zhiyong"
 <zhiyong.yang@intel.com>
Thread-Topic: [PATCH] app/pdump: fix port id storage size
Thread-Index: AQHUe1z3w6b52URIsEqrBHLzgDwFcKVN8I6AgAEDljA=
Date: Wed, 14 Nov 2018 08:39:11 +0000
Message-ID: <6DC05C7C5F25994B81B3F2F214251F660205020E@IRSMSX104.ger.corp.intel.com>
References: <20181113142655.28535-1-marko.kovacevic@intel.com>
 <3AEA2BF9852C6F48A459DA490692831F2A3D304B@irsmsx110.ger.corp.intel.com>
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A3D304B@irsmsx110.ger.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTE4Yjg4YmYtZDRkNi00NGU5LWIzNGQtZWYzMDY1ZjhiMmNhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieHlDSmVLTnFKaHN0N1B2UHlsdjFNMTYyWFlXOUdlUGJnVnVQQitGSWV5K3hzTnFQa0QyM1FYWEVPVFd2WUZjUSJ9
x-ctpclassification: CTP_NT
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] app/pdump: fix port id storage size
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Nov 2018 08:39:15 -0000

> > port_id size should be uint16_t,
> > fix where it is defined as uint8_t
> >
> > Fixes: f8244c6399d9 ("ethdev: increase port id range")
> > Cc: zhiyong.yang@intel.com
> >
> > Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
> > ---
> >  app/pdump/main.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/app/pdump/main.c b/app/pdump/main.c index
> > d96556e..baabd04
> > 100644
> > --- a/app/pdump/main.c
> > +++ b/app/pdump/main.c
> > @@ -266,7 +266,7 @@ parse_pdump(const char *optarg)
> >  				&parse_uint_value, &v);
> >  		if (ret < 0)
>=20
> Can you also int type  to unit16_t for below two.
>=20
>         int rx_vdev_id;
>         int tx_vdev_id;
>=20
> Thanks,
> Reshma

Sure Reshma will do it right now.

Marko K.