* [dpdk-dev] [PATCH] app/pdump: fix port id storage size
@ 2018-11-13 14:26 Marko Kovacevic
2018-11-13 14:30 ` Marko Kovacevic
2018-11-13 17:09 ` [dpdk-dev] [PATCH] " Pattan, Reshma
0 siblings, 2 replies; 9+ messages in thread
From: Marko Kovacevic @ 2018-11-13 14:26 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, reshma.pattan, Marko Kovacevic, zhiyong.yang
port_id size should be uint16_t,
fix where it is defined as uint8_t
Fixes: f8244c6399d9 ("ethdev: increase port id range")
Cc: zhiyong.yang@intel.com
Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
---
app/pdump/main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/app/pdump/main.c b/app/pdump/main.c
index d96556e..baabd04 100644
--- a/app/pdump/main.c
+++ b/app/pdump/main.c
@@ -266,7 +266,7 @@ parse_pdump(const char *optarg)
&parse_uint_value, &v);
if (ret < 0)
goto free_kvlist;
- pt->port = (uint8_t) v.val;
+ pt->port = (uint16_t) v.val;
pt->dump_by_type = PORT_ID;
} else if (cnt2 == 1) {
ret = rte_kvargs_process(kvlist, PDUMP_PCI_ARG,
@@ -435,7 +435,7 @@ disable_pdump(struct pdump_tuples *pt)
}
static inline void
-pdump_rxtx(struct rte_ring *ring, uint8_t vdev_id, struct pdump_stats *stats)
+pdump_rxtx(struct rte_ring *ring, uint16_t vdev_id, struct pdump_stats *stats)
{
/* write input packets of port to vdev for pdump */
struct rte_mbuf *rxtx_bufs[BURST_SIZE];
@@ -462,7 +462,7 @@ pdump_rxtx(struct rte_ring *ring, uint8_t vdev_id, struct pdump_stats *stats)
}
static void
-free_ring_data(struct rte_ring *ring, uint8_t vdev_id,
+free_ring_data(struct rte_ring *ring, uint16_t vdev_id,
struct pdump_stats *stats)
{
while (rte_ring_count(ring))
--
2.9.5
^ permalink raw reply [flat|nested] 9+ messages in thread* [dpdk-dev] [PATCH] app/pdump: fix port id storage size
2018-11-13 14:26 [dpdk-dev] [PATCH] app/pdump: fix port id storage size Marko Kovacevic
@ 2018-11-13 14:30 ` Marko Kovacevic
2018-11-13 14:33 ` [dpdk-dev] [PATCH v2] " Marko Kovacevic
2018-11-13 17:09 ` [dpdk-dev] [PATCH] " Pattan, Reshma
1 sibling, 1 reply; 9+ messages in thread
From: Marko Kovacevic @ 2018-11-13 14:30 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, reshma.pattan, Marko Kovacevic, zhiyong.yang
port_id size should be uint16_t,
fix where it is defined as uint8_t
Fixes: f8244c6399d9 ("ethdev: increase port id range")
Cc: zhiyong.yang@intel.com
Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
---
app/pdump/main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/app/pdump/main.c b/app/pdump/main.c
index d96556e..baabd04 100644
--- a/app/pdump/main.c
+++ b/app/pdump/main.c
@@ -266,7 +266,7 @@ parse_pdump(const char *optarg)
&parse_uint_value, &v);
if (ret < 0)
goto free_kvlist;
- pt->port = (uint8_t) v.val;
+ pt->port = (uint16_t) v.val;
pt->dump_by_type = PORT_ID;
} else if (cnt2 == 1) {
ret = rte_kvargs_process(kvlist, PDUMP_PCI_ARG,
@@ -435,7 +435,7 @@ disable_pdump(struct pdump_tuples *pt)
}
static inline void
-pdump_rxtx(struct rte_ring *ring, uint8_t vdev_id, struct pdump_stats *stats)
+pdump_rxtx(struct rte_ring *ring, uint16_t vdev_id, struct pdump_stats *stats)
{
/* write input packets of port to vdev for pdump */
struct rte_mbuf *rxtx_bufs[BURST_SIZE];
@@ -462,7 +462,7 @@ pdump_rxtx(struct rte_ring *ring, uint8_t vdev_id, struct pdump_stats *stats)
}
static void
-free_ring_data(struct rte_ring *ring, uint8_t vdev_id,
+free_ring_data(struct rte_ring *ring, uint16_t vdev_id,
struct pdump_stats *stats)
{
while (rte_ring_count(ring))
--
2.9.5
^ permalink raw reply [flat|nested] 9+ messages in thread* [dpdk-dev] [PATCH v2] app/pdump: fix port id storage size
2018-11-13 14:30 ` Marko Kovacevic
@ 2018-11-13 14:33 ` Marko Kovacevic
2018-11-14 8:56 ` [dpdk-dev] [PATCH v3] " Marko Kovacevic
0 siblings, 1 reply; 9+ messages in thread
From: Marko Kovacevic @ 2018-11-13 14:33 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, reshma.pattan, Marko Kovacevic, zhiyong.yang, stable
port_id size should be uint16_t,
fix where it is defined as uint8_t
Fixes: f8244c6399d9 ("ethdev: increase port id range")
Cc: zhiyong.yang@intel.com
Cc: stable@dpdk.org
Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
--
v2:
Added cc to stable
---
app/pdump/main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/app/pdump/main.c b/app/pdump/main.c
index d96556e..baabd04 100644
--- a/app/pdump/main.c
+++ b/app/pdump/main.c
@@ -266,7 +266,7 @@ parse_pdump(const char *optarg)
&parse_uint_value, &v);
if (ret < 0)
goto free_kvlist;
- pt->port = (uint8_t) v.val;
+ pt->port = (uint16_t) v.val;
pt->dump_by_type = PORT_ID;
} else if (cnt2 == 1) {
ret = rte_kvargs_process(kvlist, PDUMP_PCI_ARG,
@@ -435,7 +435,7 @@ disable_pdump(struct pdump_tuples *pt)
}
static inline void
-pdump_rxtx(struct rte_ring *ring, uint8_t vdev_id, struct pdump_stats *stats)
+pdump_rxtx(struct rte_ring *ring, uint16_t vdev_id, struct pdump_stats *stats)
{
/* write input packets of port to vdev for pdump */
struct rte_mbuf *rxtx_bufs[BURST_SIZE];
@@ -462,7 +462,7 @@ pdump_rxtx(struct rte_ring *ring, uint8_t vdev_id, struct pdump_stats *stats)
}
static void
-free_ring_data(struct rte_ring *ring, uint8_t vdev_id,
+free_ring_data(struct rte_ring *ring, uint16_t vdev_id,
struct pdump_stats *stats)
{
while (rte_ring_count(ring))
--
2.9.5
^ permalink raw reply [flat|nested] 9+ messages in thread* [dpdk-dev] [PATCH v3] app/pdump: fix port id storage size
2018-11-13 14:33 ` [dpdk-dev] [PATCH v2] " Marko Kovacevic
@ 2018-11-14 8:56 ` Marko Kovacevic
2018-11-14 10:28 ` Pattan, Reshma
0 siblings, 1 reply; 9+ messages in thread
From: Marko Kovacevic @ 2018-11-14 8:56 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, reshma.pattan, Marko Kovacevic, zhiyong.yang, stable
port_id size should be uint16_t,
fix where it is defined as uint8_t
Fixes: f8244c6399d9 ("ethdev: increase port id range")
Cc: zhiyong.yang@intel.com
Cc: stable@dpdk.org
Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
--
v2:
Added cc to stable
v3:
Changed two more values to uint16_t (Reshma)
---
app/pdump/main.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/app/pdump/main.c b/app/pdump/main.c
index d96556e..9e86bf6 100644
--- a/app/pdump/main.c
+++ b/app/pdump/main.c
@@ -119,8 +119,8 @@ struct pdump_tuples {
/* params for packet dumping */
enum pdump_by dump_by_type;
- int rx_vdev_id;
- int tx_vdev_id;
+ uint16_t rx_vdev_id;
+ uint16_t tx_vdev_id;
enum pcap_stream rx_vdev_stream_type;
enum pcap_stream tx_vdev_stream_type;
bool single_pdump_dev;
@@ -266,7 +266,7 @@ parse_pdump(const char *optarg)
&parse_uint_value, &v);
if (ret < 0)
goto free_kvlist;
- pt->port = (uint8_t) v.val;
+ pt->port = (uint16_t) v.val;
pt->dump_by_type = PORT_ID;
} else if (cnt2 == 1) {
ret = rte_kvargs_process(kvlist, PDUMP_PCI_ARG,
@@ -435,7 +435,7 @@ disable_pdump(struct pdump_tuples *pt)
}
static inline void
-pdump_rxtx(struct rte_ring *ring, uint8_t vdev_id, struct pdump_stats *stats)
+pdump_rxtx(struct rte_ring *ring, uint16_t vdev_id, struct pdump_stats *stats)
{
/* write input packets of port to vdev for pdump */
struct rte_mbuf *rxtx_bufs[BURST_SIZE];
@@ -462,7 +462,7 @@ pdump_rxtx(struct rte_ring *ring, uint8_t vdev_id, struct pdump_stats *stats)
}
static void
-free_ring_data(struct rte_ring *ring, uint8_t vdev_id,
+free_ring_data(struct rte_ring *ring, uint16_t vdev_id,
struct pdump_stats *stats)
{
while (rte_ring_count(ring))
--
2.9.5
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH v3] app/pdump: fix port id storage size
2018-11-14 8:56 ` [dpdk-dev] [PATCH v3] " Marko Kovacevic
@ 2018-11-14 10:28 ` Pattan, Reshma
2018-11-18 20:42 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
0 siblings, 1 reply; 9+ messages in thread
From: Pattan, Reshma @ 2018-11-14 10:28 UTC (permalink / raw)
To: Kovacevic, Marko, dev; +Cc: Yigit, Ferruh, Yang, Zhiyong, stable
> -----Original Message-----
> From: Kovacevic, Marko
> Sent: Wednesday, November 14, 2018 8:57 AM
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Pattan, Reshma
> <reshma.pattan@intel.com>; Kovacevic, Marko <marko.kovacevic@intel.com>;
> Yang, Zhiyong <zhiyong.yang@intel.com>; stable@dpdk.org
> Subject: [PATCH v3] app/pdump: fix port id storage size
>
> port_id size should be uint16_t,
> fix where it is defined as uint8_t
>
> Fixes: f8244c6399d9 ("ethdev: increase port id range")
> Cc: zhiyong.yang@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
Acked-by: Reshma Pattan <reshma.pattan@intel.com>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/pdump: fix port id storage size
2018-11-14 10:28 ` Pattan, Reshma
@ 2018-11-18 20:42 ` Thomas Monjalon
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Monjalon @ 2018-11-18 20:42 UTC (permalink / raw)
To: Kovacevic, Marko
Cc: stable, Pattan, Reshma, dev, Yigit, Ferruh, Yang, Zhiyong
14/11/2018 11:28, Pattan, Reshma:
> From: Kovacevic, Marko
> >
> > port_id size should be uint16_t,
> > fix where it is defined as uint8_t
> >
> > Fixes: f8244c6399d9 ("ethdev: increase port id range")
> > Cc: zhiyong.yang@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
>
> Acked-by: Reshma Pattan <reshma.pattan@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] app/pdump: fix port id storage size
2018-11-13 14:26 [dpdk-dev] [PATCH] app/pdump: fix port id storage size Marko Kovacevic
2018-11-13 14:30 ` Marko Kovacevic
@ 2018-11-13 17:09 ` Pattan, Reshma
2018-11-14 8:39 ` Kovacevic, Marko
1 sibling, 1 reply; 9+ messages in thread
From: Pattan, Reshma @ 2018-11-13 17:09 UTC (permalink / raw)
To: Kovacevic, Marko, dev; +Cc: Yigit, Ferruh, Yang, Zhiyong
> -----Original Message-----
> From: Kovacevic, Marko
> Sent: Tuesday, November 13, 2018 2:27 PM
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Pattan, Reshma
> <reshma.pattan@intel.com>; Kovacevic, Marko <marko.kovacevic@intel.com>;
> Yang, Zhiyong <zhiyong.yang@intel.com>
> Subject: [PATCH] app/pdump: fix port id storage size
>
> port_id size should be uint16_t,
> fix where it is defined as uint8_t
>
> Fixes: f8244c6399d9 ("ethdev: increase port id range")
> Cc: zhiyong.yang@intel.com
>
> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
> ---
> app/pdump/main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/app/pdump/main.c b/app/pdump/main.c index d96556e..baabd04
> 100644
> --- a/app/pdump/main.c
> +++ b/app/pdump/main.c
> @@ -266,7 +266,7 @@ parse_pdump(const char *optarg)
> &parse_uint_value, &v);
> if (ret < 0)
Can you also int type to unit16_t for below two.
int rx_vdev_id;
int tx_vdev_id;
Thanks,
Reshma
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH] app/pdump: fix port id storage size
2018-11-13 17:09 ` [dpdk-dev] [PATCH] " Pattan, Reshma
@ 2018-11-14 8:39 ` Kovacevic, Marko
2018-11-14 10:00 ` Pattan, Reshma
0 siblings, 1 reply; 9+ messages in thread
From: Kovacevic, Marko @ 2018-11-14 8:39 UTC (permalink / raw)
To: Pattan, Reshma, dev; +Cc: Yigit, Ferruh, Yang, Zhiyong
> > port_id size should be uint16_t,
> > fix where it is defined as uint8_t
> >
> > Fixes: f8244c6399d9 ("ethdev: increase port id range")
> > Cc: zhiyong.yang@intel.com
> >
> > Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
> > ---
> > app/pdump/main.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/app/pdump/main.c b/app/pdump/main.c index
> > d96556e..baabd04
> > 100644
> > --- a/app/pdump/main.c
> > +++ b/app/pdump/main.c
> > @@ -266,7 +266,7 @@ parse_pdump(const char *optarg)
> > &parse_uint_value, &v);
> > if (ret < 0)
>
> Can you also int type to unit16_t for below two.
>
> int rx_vdev_id;
> int tx_vdev_id;
>
> Thanks,
> Reshma
Sure Reshma will do it right now.
Marko K.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH] app/pdump: fix port id storage size
2018-11-14 8:39 ` Kovacevic, Marko
@ 2018-11-14 10:00 ` Pattan, Reshma
0 siblings, 0 replies; 9+ messages in thread
From: Pattan, Reshma @ 2018-11-14 10:00 UTC (permalink / raw)
To: Kovacevic, Marko, dev; +Cc: Yigit, Ferruh, Yang, Zhiyong
> -----Original Message-----
> From: Kovacevic, Marko
> Sent: Wednesday, November 14, 2018 8:39 AM
> To: Pattan, Reshma <reshma.pattan@intel.com>; dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Yang, Zhiyong
> <zhiyong.yang@intel.com>
> Subject: RE: [PATCH] app/pdump: fix port id storage size
>
> > > port_id size should be uint16_t,
> > > fix where it is defined as uint8_t
> > >
> > > Fixes: f8244c6399d9 ("ethdev: increase port id range")
> > > Cc: zhiyong.yang@intel.com
> > >
> > > Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
Acked-by: Reshma Pattan <reshma.pattan@intel.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-11-18 20:42 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-13 14:26 [dpdk-dev] [PATCH] app/pdump: fix port id storage size Marko Kovacevic
2018-11-13 14:30 ` Marko Kovacevic
2018-11-13 14:33 ` [dpdk-dev] [PATCH v2] " Marko Kovacevic
2018-11-14 8:56 ` [dpdk-dev] [PATCH v3] " Marko Kovacevic
2018-11-14 10:28 ` Pattan, Reshma
2018-11-18 20:42 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-11-13 17:09 ` [dpdk-dev] [PATCH] " Pattan, Reshma
2018-11-14 8:39 ` Kovacevic, Marko
2018-11-14 10:00 ` Pattan, Reshma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).