From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 51EB72BAC for ; Fri, 15 Mar 2019 11:40:09 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Mar 2019 03:40:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,481,1544515200"; d="scan'208";a="134294081" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga003.jf.intel.com with ESMTP; 15 Mar 2019 03:40:00 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.56]) by IRSMSX107.ger.corp.intel.com ([169.254.10.15]) with mapi id 14.03.0415.000; Fri, 15 Mar 2019 10:39:59 +0000 From: "Kovacevic, Marko" To: Rami Rosen , "dev@dpdk.org" CC: "Mcnamara, John" , "Richardson, Bruce" Thread-Topic: [PATCH ] doc: fix two typos in contributing guide Thread-Index: AQHU2xAyrwGIEJKAVkSPDoTYbF97tKYMgKXw Date: Fri, 15 Mar 2019 10:39:58 +0000 Message-ID: <6DC05C7C5F25994B81B3F2F214251F66020A7FA8@IRSMSX104.ger.corp.intel.com> References: <20190315091900.18996-1-ramirose@gmail.com> In-Reply-To: <20190315091900.18996-1-ramirose@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmMzOWNiMGUtZWQ0Zi00ODA3LWExYWItOWMzYmEzZWQxY2MzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicGQzWkxHUWpRWWkxYzlJa1V3dDg0SVRESVJXcWViMVVxd0xXTlNlSVAxcWtNVlg4cGxzR0F5Q09iaHorYmp1ZyJ9 x-ctpclassification: CTP_NT x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH ] doc: fix two typos in contributing guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Mar 2019 10:40:09 -0000 > This patch fixes two typos in the coding style part of DPDK contributing = guide: >=20 > - The header entry should have .h file instead of .c file. > - The will->This will >=20 > Fixes: 44a6dface13b ("doc: describe how to add new components") >=20 > Signed-off-by: Rami Rosen > --- > doc/guides/contributing/coding_style.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/doc/guides/contributing/coding_style.rst > b/doc/guides/contributing/coding_style.rst > index d96698a73..656563dde 100644 > --- a/doc/guides/contributing/coding_style.rst > +++ b/doc/guides/contributing/coding_style.rst > @@ -825,10 +825,10 @@ format. > .. code-block:: python >=20 > sources =3D files('file1.c', ...) > - headers =3D files('file1.c', ...) > + headers =3D files('file1.h', ...) >=20 >=20 > -The will build based on a number of conventions and assumptions within t= he > DPDK > +This will build based on a number of conventions and assumptions within > +the DPDK > itself, for example, that the library name is the same as the directory = name > in which the files are stored. Acked-by: Marko Kovacevic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id EE2BDA0096 for ; Fri, 15 Mar 2019 11:40:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2AF722C17; Fri, 15 Mar 2019 11:40:11 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 51EB72BAC for ; Fri, 15 Mar 2019 11:40:09 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Mar 2019 03:40:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,481,1544515200"; d="scan'208";a="134294081" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga003.jf.intel.com with ESMTP; 15 Mar 2019 03:40:00 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.56]) by IRSMSX107.ger.corp.intel.com ([169.254.10.15]) with mapi id 14.03.0415.000; Fri, 15 Mar 2019 10:39:59 +0000 From: "Kovacevic, Marko" To: Rami Rosen , "dev@dpdk.org" CC: "Mcnamara, John" , "Richardson, Bruce" Thread-Topic: [PATCH ] doc: fix two typos in contributing guide Thread-Index: AQHU2xAyrwGIEJKAVkSPDoTYbF97tKYMgKXw Date: Fri, 15 Mar 2019 10:39:58 +0000 Message-ID: <6DC05C7C5F25994B81B3F2F214251F66020A7FA8@IRSMSX104.ger.corp.intel.com> References: <20190315091900.18996-1-ramirose@gmail.com> In-Reply-To: <20190315091900.18996-1-ramirose@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmMzOWNiMGUtZWQ0Zi00ODA3LWExYWItOWMzYmEzZWQxY2MzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicGQzWkxHUWpRWWkxYzlJa1V3dDg0SVRESVJXcWViMVVxd0xXTlNlSVAxcWtNVlg4cGxzR0F5Q09iaHorYmp1ZyJ9 x-ctpclassification: CTP_NT x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH ] doc: fix two typos in contributing guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190315103958.GKVDVk-eB5t0DEHDtO6XimSjUP-lTTGT2sOKnHNMOkI@z> > This patch fixes two typos in the coding style part of DPDK contributing = guide: >=20 > - The header entry should have .h file instead of .c file. > - The will->This will >=20 > Fixes: 44a6dface13b ("doc: describe how to add new components") >=20 > Signed-off-by: Rami Rosen > --- > doc/guides/contributing/coding_style.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/doc/guides/contributing/coding_style.rst > b/doc/guides/contributing/coding_style.rst > index d96698a73..656563dde 100644 > --- a/doc/guides/contributing/coding_style.rst > +++ b/doc/guides/contributing/coding_style.rst > @@ -825,10 +825,10 @@ format. > .. code-block:: python >=20 > sources =3D files('file1.c', ...) > - headers =3D files('file1.c', ...) > + headers =3D files('file1.h', ...) >=20 >=20 > -The will build based on a number of conventions and assumptions within t= he > DPDK > +This will build based on a number of conventions and assumptions within > +the DPDK > itself, for example, that the library name is the same as the directory = name > in which the files are stored. Acked-by: Marko Kovacevic